[web] Show option to change role from the members modal
ClosedPublic
Actions

Authored by rohan on Jun 7 2023, 4:59 AM.

Details

Reviewers

atul
ginsu

Commits

rCOMM11eb42d4930f: [web] Show option to change role from the members modal

Summary

As a first step in allowing admins to change member roles, the member panel option needed to be refactored to a more general approach to 'Change Role', as opposed to just toggling an admin status.

https://linear.app/comm/issue/ENG-4037/show-option-to-change-role-from-the-members-modal

Test Plan

Confirm that the dropdown shows the updated icon and text

Screenshot 2023-06-07 at 8.13.20 AM.png (1×1 px, 99 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Jun 7 2023, 4:59 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 7 2023, 4:59 AM

rohan added a child revision: D8136: [web] Implement a custom dropdown menu component.Jun 7 2023, 5:01 AM

rohan edited the test plan for this revision. (Show Details)Jun 7 2023, 5:13 AM

rohan attached a referenced file: F575200: Screenshot 2023-06-07 at 8.13.20 AM.png. (Show Details)

Harbormaster completed remote builds in B20077: Diff 27512.Jun 7 2023, 5:16 AM

rohan requested review of this revision.Jun 7 2023, 5:16 AM

Don't think the plus-circle icon makes sense for "Change Role," but defer to @ted on that.

web/modals/threads/members/member.react.js
77 ↗	(On Diff #27512)	Are we sure `plus-circle` is an appropriate icon for "Change Role"? CC @ted for his thoughts

This revision is now accepted and ready to land.Jun 7 2023, 12:53 PM

rohan added inline comments.Jun 7 2023, 1:14 PM

web/modals/threads/members/member.react.js
77 ↗	(On Diff #27512)	The plus-circle seems to be used in the designs (screenshot below is from Figma) so I used that one. Happy to change though

rohan attached a referenced file: F575734: Screenshot 2023-06-07 at 4.12.52 PM.png. (Show Details)Jun 7 2023, 1:14 PM

rohan mentioned this in D8136: [web] Implement a custom dropdown menu component.Jun 9 2023, 12:58 PM

Remove memberIsAdmin import

Harbormaster completed remote builds in B20155: Diff 27605.Jun 9 2023, 1:57 PM

Rebase

Harbormaster completed remote builds in B20382: Diff 27936.Jun 21 2023, 8:21 AM

Closed by commit rCOMM11eb42d4930f: [web] Show option to change role from the members modal (authored by rohan). · Explain WhyJun 21 2023, 8:41 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM11eb42d4930f: [web] Show option to change role from the members modal.

ashoat added inline comments.Jun 27 2023, 10:25 AM

web/modals/threads/members/member.react.js
77 ↗	(On Diff #27512)	I agree with @atul. @ted doesn't seem to have responded here... pinging him again

ashoat added inline comments.Jun 28 2023, 2:54 PM

web/modals/threads/members/member.react.js
77 ↗	(On Diff #27512)	Still no response from @ted – @rohan can you make sure to ping him about this? It would be good to create a Linear task to track