Page MenuHomePhabricator

[web] Add functionality on save to actually change a member's role
ClosedPublic

Authored by rohan on Jun 7 2023, 5:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 12:40 AM
Unknown Object (File)
Sat, Nov 9, 3:00 PM
Unknown Object (File)
Sat, Nov 9, 2:01 PM
Unknown Object (File)
Sat, Nov 9, 1:22 PM
Unknown Object (File)
Sat, Nov 9, 12:19 PM
Unknown Object (File)
Sat, Nov 9, 11:39 AM
Unknown Object (File)
Sat, Nov 9, 11:34 AM
Unknown Object (File)
Sat, Nov 9, 8:38 AM
Subscribers

Details

Summary

This diff adds functionality to clicking the save button, so when it is clicked the member's role is actually changed. There is already keyserver support for this, so the work here was entirely front
end.

https://linear.app/comm/issue/ENG-4040/add-functionality-on-save-to-actually-change-a-members-role

Depends on D8139

Test Plan

Please see the video below showing the working save button

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan requested review of this revision.Jun 7 2023, 5:25 AM
web/modals/threads/members/change-member-role-modal.react.js
71–79 ↗(On Diff #27517)

Nit: this doesn't have to be an async function in order to return a promise

This revision is now accepted and ready to land.Jun 9 2023, 3:26 PM
This revision was landed with ongoing or failed builds.Jun 21 2023, 8:41 AM
This revision was automatically updated to reflect the committed changes.
web/modals/threads/members/change-member-role-modal.react.js
65–71

Shorthand