Page MenuHomePhabricator
Differential D8142

[lib] Update robotext for role changes
ClosedPublic
Actions

Authored by rohan on Jun 7 2023, 5:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 10:37 PM
Unknown Object (File)
Thu, Nov 7, 10:37 PM
Unknown Object (File)
Thu, Nov 7, 10:37 PM
Unknown Object (File)
Thu, Nov 7, 10:30 PM
Unknown Object (File)
Thu, Nov 7, 7:32 PM
Unknown Object (File)
Mon, Nov 4, 10:53 AM
Unknown Object (File)
Mon, Nov 4, 10:53 AM
Unknown Object (File)
Mon, Nov 4, 10:53 AM
View All 99 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
atul
ginsu
Commits
rCOMMf65b2b0607da: [lib] Update robotext for role changes
Summary

Small change, the designs just indicate that a different robotext should be used for role changes.

Adding @ashoat as blocking since it involves copy changes

https://linear.app/comm/issue/ENG-4041/prevent-changing-the-only-admin-role-in-a-community

Depends on D8141

Test Plan

Please see the updated robotext below

Screenshot 2023-06-07 at 8.43.42 AM.png (1×3 px, 454 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan created this revision.Jun 7 2023, 5:12 AM
Herald added a subscriber: tomek. · View Herald TranscriptJun 7 2023, 5:12 AM
Harbormaster completed remote builds in B20084: Diff 27519.Jun 7 2023, 5:30 AM
rohan requested review of this revision.Jun 7 2023, 5:30 AM
rohan edited the test plan for this revision. (Show Details)Jun 7 2023, 5:44 AM
rohan attached a referenced file: F575278: Screenshot 2023-06-07 at 8.43.42 AM.png. (Show Details)
ashoat accepted this revision.Jun 7 2023, 2:18 PM
This revision is now accepted and ready to land.Jun 7 2023, 2:18 PM
rohan added a child revision: D8155: [native] Show option to change role from the members list.Jun 9 2023, 11:19 AM
rohan updated this revision to Diff 27944.Jun 21 2023, 8:05 AM

Rebase

This revision was landed with ongoing or failed builds.Jun 21 2023, 8:42 AM
Closed by commit rCOMMf65b2b0607da: [lib] Update robotext for role changes (authored by rohan). · Explain Why
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMMf65b2b0607da: [lib] Update robotext for role changes.
Harbormaster completed remote builds in B20390: Diff 27944.Jun 21 2023, 8:58 AM
rohan mentioned this in D8502: [keyserver/lib] Update the change_role message spec to include a role name field in the DB.Jul 27 2023, 10:05 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
7 lines

Diff 27963

View Options

lib/shared/messages/change-role-message-spec.js

Loading...