Details
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/account/registration/registration-terms.react.js | ||
|---|---|---|
| 5 | I tried using expo-image instead of React Native's one, but it didn't seem to handle the png resource correctly for some reason (rendered empty). cc @bartek | |
| 18 | I initially tried exporting an SVG from Figma. It rendered okay in Chrome, but the gradients didn't seem to work with react-native-svg:  For context, here's the react-native-svg component I had drafted from the .svg source: https://gist.github.com/Ashoat/70c485b47bd71d7211aa86631aaf15c3 cc @ted | |
| 121 | This was the only color in native/themes/colors.js that used violetDark100 in dark mode. link and purpleLink use violetDark100 in light mode, but in dark mode they both use violetLight100. @ted, are you sure that we should be using violetDark100 and not violetLight100 here? If so, should we consider updating link and purpleLink in dark mode to match? | |
| native/account/registration/registration-terms.react.js | ||
|---|---|---|
| 18 | Generally prefer vector assets instead of raster ones, but don't think it matters much here | |
| native/account/registration/registration-terms.react.js | ||
|---|---|---|
| 18 | Ok disregard, submitted comment before your annotation showed up | |
| native/account/registration/registration-terms.react.js | ||
|---|---|---|
| 121 | Thanks for the ping and catch! I took a quick look at our app and did find the violetLight100 being used for text links such as here:  I think that shade of violet works here with the background its in. So let's not change anything but update this new design to use violetLight100 So I think this works: hyperlinkText: {
color: 'purpleLink', | |