[native] Update KeyserverSelection to take URL instead of username as input
ClosedPublic
Actions

Authored by ashoat on Jun 13 2023, 5:16 PM.

Details

Reviewers

atul
ginsu

Commits

rCOMM8f5a657a9f98: [native] Update KeyserverSelection to take URL instead of username as input

Summary

Minor changes to indicate to the user that we are expecting them to input a URL.

Depends on D8193

Test Plan

Confirm placeholder appears correctly
Confirm on-screen keyboard includes ".com" key on iOS simulator

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 13 2023, 5:16 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 13 2023, 5:16 PM

ashoat added a child revision: D8195: [native] Part 1: use user's keyserver selection in registration flow.Jun 13 2023, 5:16 PM

Harbormaster completed remote builds in B20213: Diff 27688.Jun 13 2023, 5:35 PM

ashoat requested review of this revision.Jun 13 2023, 5:35 PM

ginsu accepted this revision.Jun 13 2023, 7:08 PM

This revision is now accepted and ready to land.Jun 13 2023, 7:08 PM

ashoat mentioned this in D8198: [native] Add error handling to KeyserverSelection.Jun 14 2023, 1:04 PM

Disable autoCorrect following @ginsu's feedback in D8198. Also disabled autoCapitalize

This revision was landed with ongoing or failed builds.Jun 14 2023, 1:14 PM

Closed by commit rCOMM8f5a657a9f98: [native] Update KeyserverSelection to take URL instead of username as input. · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8f5a657a9f98: [native] Update KeyserverSelection to take URL instead of username as input.

Harbormaster completed remote builds in B20245: Diff 27727.Jun 14 2023, 1:28 PM

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

keyserver-selection.react.js

5 lines

Diff 27733

View Options

native/account/registration/keyserver-selection.react.js

[native] Update KeyserverSelection to take URL instead of username as inputClosedPublicActions