Page MenuHomePhabricator

[native] Add error handling to KeyserverSelection
ClosedPublic

Authored by ashoat on Jun 13 2023, 10:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 3:00 AM
Unknown Object (File)
Mon, Nov 4, 10:40 AM
Unknown Object (File)
Mon, Nov 4, 10:40 AM
Unknown Object (File)
Mon, Nov 4, 10:40 AM
Unknown Object (File)
Mon, Nov 4, 10:40 AM
Unknown Object (File)
Mon, Nov 4, 10:39 AM
Unknown Object (File)
Mon, Nov 4, 10:39 AM
Unknown Object (File)
Mon, Nov 4, 10:39 AM
Subscribers

Details

Summary

I want to display an error to the user if we aren't able to reach the keyserver that they've selected.

Depends on D8197

Test Plan

First, I overrode defaultURLPrefix in native/utils/url-utils.js to return some random string. That made sure that the "default" of Ashoat's keyserver does not work, and makes it so the registration flow only worked if the user selected a custom keyserver and all of the server calls in the registration flow used that custom keyserver.

Next, I played around with the screen:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat edited the test plan for this revision. (Show Details)

Probably outside the scope of this diff, but might be worth to consider disabling auto correct on the Enter a keyserver RegistrationTextInput in a follow up diff. Would avoid the situation in the demo video where "localhost" => "local host" and I think if people had unique keyserver names in the future, autocorrect here could be annoying in the user experience

This revision is now accepted and ready to land.Jun 13 2023, 12:56 PM
In D8198#242231, @ginsu wrote:

Probably outside the scope of this diff, but might be worth to consider disabling auto correct on the Enter a keyserver RegistrationTextInput in a follow up diff. Would avoid the situation in the demo video where "localhost" => "local host" and I think if people had unique keyserver names in the future, autocorrect here could be annoying in the user experience

Good call. I'll do that in D8194

Disable autoCorrect following @ginsu's feedback in D8198. Also disabled autoCapitalize

Oops, updated the wrong diff

This revision was landed with ongoing or failed builds.Jun 14 2023, 6:14 AM
This revision was automatically updated to reflect the committed changes.