Details

Reviewers

atul
ginsu

Commits

rCOMMc07b9f31f489: [native] Add error handling to KeyserverSelection

Summary

I want to display an error to the user if we aren't able to reach the keyserver that they've selected.

Depends on D8197

Test Plan

First, I overrode defaultURLPrefix in native/utils/url-utils.js to return some random string. That made sure that the "default" of Ashoat's keyserver does not work, and makes it so the registration flow only worked if the user selected a custom keyserver and all of the server calls in the registration flow used that custom keyserver.

Next, I played around with the screen:

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/keyserverversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jun 13 2023, 10:22 AM

Herald added a subscriber: tomek. · View Herald TranscriptJun 13 2023, 10:22 AM

ashoat edited the test plan for this revision. (Show Details)Jun 13 2023, 10:25 AM

ashoat edited the test plan for this revision. (Show Details)

Minor

Harbormaster completed remote builds in B20217: Diff 27692.Jun 13 2023, 11:03 AM

Harbormaster completed remote builds in B20219: Diff 27694.Jun 13 2023, 11:17 AM

ashoat requested review of this revision.Jun 13 2023, 11:17 AM

Probably outside the scope of this diff, but might be worth to consider disabling auto correct on the Enter a keyserver RegistrationTextInput in a follow up diff. Would avoid the situation in the demo video where "localhost" => "local host" and I think if people had unique keyserver names in the future, autocorrect here could be annoying in the user experience

This revision is now accepted and ready to land.Jun 13 2023, 12:56 PM

In D8198#242231, @ginsu wrote:

Probably outside the scope of this diff, but might be worth to consider disabling auto correct on the Enter a keyserver RegistrationTextInput in a follow up diff. Would avoid the situation in the demo video where "localhost" => "local host" and I think if people had unique keyserver names in the future, autocorrect here could be annoying in the user experience

Good call. I'll do that in D8194