Details
Details
- Reviewers
michal atul - Commits
- rCOMM6a7006be3890: [keyserver][lib] Introduce `version` endpoint
Tested in combination with the rest of the stack as follows:
- Override defaultURLPrefix in native/utils/url-utils.js to return some random string. This makes sure that the "default" of Ashoat's keyserver does not work, and makes it so the registration flow only works if the user selects a custom keyserver and all of the server calls in the registration flow use that custom keyserver
- Test the registration flow end-to-end for an Ethereum account
- Test the registration flow end-to-end for a username/password account
- Test the registration flow end-to-end for a username/password account with a custom avatar that requires an image upload
- Make sure that for all registrations, the correct avatar appears in the ChatThreadList when the RegistrationNavigator dismisses
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks good
Its initial use case will be simply to check if a keyserver exists at this URL.
I don't have context on future uses for this endpoint, but will we have to worry about scenarios where user-deployed "malicious" keyservers could potentially "lie" about their version?
Comment Actions
I don't have context on future uses for this endpoint, but will we have to worry about scenarios where user-deployed "malicious" keyservers could potentially "lie" about their version?
Yeah, but not much we can do about that...