[keyserver][lib] Introduce `version` endpoint
ClosedPublic
Actions

Authored by ashoat on Jun 13 2023, 9:53 AM.

Details

Reviewers

michal
atul

Commits

rCOMM6a7006be3890: [keyserver][lib] Introduce `version` endpoint

Summary

This endpoint returns the current version of the keyserver. Its initial use case will be simply to check if a keyserver exists at this URL.

More context in ENG-3952.

Depends on D8189

Test Plan

Tested in combination with the rest of the stack as follows:

Override defaultURLPrefix in native/utils/url-utils.js to return some random string. This makes sure that the "default" of Ashoat's keyserver does not work, and makes it so the registration flow only works if the user selects a custom keyserver and all of the server calls in the registration flow use that custom keyserver
Test the registration flow end-to-end for an Ethereum account
Test the registration flow end-to-end for a username/password account
Test the registration flow end-to-end for a username/password account with a custom avatar that requires an image upload
Make sure that for all registrations, the correct avatar appears in the ChatThreadList when the RegistrationNavigator dismisses

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 13 2023, 9:53 AM

Herald added a subscriber: tomek. · View Herald TranscriptJun 13 2023, 9:53 AM

Avoid redeclaring the response object on every invocation

ashoat added a child revision: D8191: [lib] Introduce action for new getVersion endpoint.Jun 13 2023, 9:55 AM

Harbormaster completed remote builds in B20208: Diff 27683.Jun 13 2023, 10:10 AM

Harbormaster completed remote builds in B20209: Diff 27684.Jun 13 2023, 10:13 AM

ashoat requested review of this revision.Jun 13 2023, 10:13 AM

Looks good

Its initial use case will be simply to check if a keyserver exists at this URL.

I don't have context on future uses for this endpoint, but will we have to worry about scenarios where user-deployed "malicious" keyservers could potentially "lie" about their version?

This revision is now accepted and ready to land.Jun 13 2023, 6:22 PM

I don't have context on future uses for this endpoint, but will we have to worry about scenarios where user-deployed "malicious" keyservers could potentially "lie" about their version?

Yeah, but not much we can do about that...

Closed by commit rCOMM6a7006be3890: [keyserver][lib] Introduce `version` endpoint (authored by ashoat). · Explain WhyJun 14 2023, 6:14 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6a7006be3890: [keyserver][lib] Introduce `version` endpoint.