Page MenuHomePhabricator

[native] Part 2: use user's keyserver selection in registration flow
ClosedPublic

Authored by ashoat on Jun 13 2023, 10:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 10:39 AM
Unknown Object (File)
Mon, Nov 4, 10:39 AM
Unknown Object (File)
Mon, Nov 4, 8:24 AM
Unknown Object (File)
Mon, Nov 4, 8:24 AM
Unknown Object (File)
Sun, Oct 27, 11:48 PM
Unknown Object (File)
Sun, Oct 27, 11:48 PM
Unknown Object (File)
Sun, Oct 27, 11:48 PM
Unknown Object (File)
Sun, Oct 27, 11:43 PM
Subscribers

Details

Summary

See comment in previous diff:

Separating this from the next diff because the approaches are slightly different. In this diff we update all of the callsites where we know the keyserver selection at "render time" (eg. we can pass it as input into a hook).

In the next diff, we'll handle callsites that only know the keyserver selection when it gets passed to a callback.

Depends on D8195

Test Plan

Tested in combination with the rest of the stack as follows:

  1. Override defaultURLPrefix in native/utils/url-utils.js to return some random string. This makes sure that the "default" of Ashoat's keyserver does not work, and makes it so the registration flow only works if the user selects a custom keyserver and all of the server calls in the registration flow use that custom keyserver
  2. Test the registration flow end-to-end for an Ethereum account
  3. Test the registration flow end-to-end for a username/password account
  4. Test the registration flow end-to-end for a username/password account with a custom avatar that requires an image upload
  5. Make sure that for all registrations, the correct avatar appears in the ChatThreadList when the RegistrationNavigator dismisses

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable