[keyserver] add removeReservedUsername method to rust-node-addon
ClosedPublic
Actions

Authored by varun on Jun 13 2023, 10:16 PM.

Details

Reviewers

• jon
bartek

Commits

rCOMMa56b59339f70: [keyserver] add removeReservedUsername method to rust-node-addon

Summary

Added an identity client method to call the removeReservedUsername RPC.
We will need to call this when an account is deleted on Ashoat's keyserver to keep the Identity service aware of which usernames should be reserved.

Depends on D8201

Test Plan

called this client method from keyserver.js with a signed message (signed by a hardcoded ed25519 key) and an existing reserved username and saw that the DDB table was updated

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jun 13 2023, 10:16 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 13 2023, 10:16 PM

Harbormaster completed remote builds in B20232: Diff 27712.Jun 13 2023, 10:33 PM

varun requested review of this revision.Jun 13 2023, 10:33 PM

• jon accepted this revision.Jun 14 2023, 7:40 AM

• jon added inline comments.

keyserver/addons/rust-node-addon/src/identity_client/remove_reserved_username.rs
21 ↗	(On Diff #27712)	Still not a fan of using such a gneeric error. Really makes debugging difficult when things start failing. Guess I'm okay with this since this is meant to be a transitional workflow