[identity] add helper functions for validating add/remove username messages
ClosedPublic
Actions

Authored by varun on Jun 16 2023, 12:38 AM.

Details

Reviewers

• jon
bartek

Commits

rCOMM9b25bfb3f8b4: [identity] add helper functions for validating add/remove username messages

Summary

validate the message and return the username to be added/removed

Depends on D8232

Test Plan

tested in subsequent diff where helper functions are called

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jun 16 2023, 12:38 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 16 2023, 12:38 AM

varun added a child revision: D8134: [identity] implement addReservedUsername and removeReservedUsername RPCs.Jun 16 2023, 12:45 AM

Harbormaster completed remote builds in B20296: Diff 27819.Jun 16 2023, 1:00 AM

varun requested review of this revision.Jun 16 2023, 1:00 AM

bartek accepted this revision.Jun 16 2023, 5:37 AM

bartek added inline comments.

services/identity/src/reserved_users.rs
78 ↗	(On Diff #27819)	The compiler will likely do it anyway, but we could possibly mark these as `#[inline]`

This revision is now accepted and ready to land.Jun 16 2023, 5:37 AM

varun added inline comments.Jun 20 2023, 12:54 PM

services/identity/src/reserved_users.rs
78 ↗	(On Diff #27819)	yeah i think the compiler will do it

Closed by commit rCOMM9b25bfb3f8b4: [identity] add helper functions for validating add/remove username messages (authored by varun). · Explain WhyJun 22 2023, 1:30 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM9b25bfb3f8b4: [identity] add helper functions for validating add/remove username messages.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

reserved_users.rs

26 lines

Diff 28019

View Options

services/identity/src/reserved_users.rs

[identity] add helper functions for validating add/remove username messagesClosedPublicActions