Differential D8201

[keyserver] add addReservedUsername method to rust-node-addon
ClosedPublic
Actions

Authored by varun on Jun 13 2023, 10:15 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 24, 8:43 AM

	Unknown Object (File)
	Wed, Apr 24, 8:43 AM

	Unknown Object (File)
	Wed, Apr 24, 8:43 AM

	Unknown Object (File)
	Wed, Apr 24, 8:43 AM

	Unknown Object (File)
	Wed, Apr 24, 8:43 AM

	Unknown Object (File)
	Wed, Apr 24, 8:41 AM

	Unknown Object (File)
	Mar 3 2024, 9:55 PM

	Unknown Object (File)
	Mar 3 2024, 9:55 PM

View All 47 Files

Subscribers

Details

Reviewers

• jon
bartek

Commits

rCOMM32518a2bb167: [keyserver] add addReservedUsername method to rust-node-addon

Summary

Added an identity client method to call the addReservedUsername RPC.
We will need to call this when a new account is registered on Ashoat's keyserver
via the old registration workflow to keep the Identity service aware of which
usernames should be reserved.

Depends on D8134

Test Plan

called this client method from keyserver.js with a signed message (signed by a hardcoded ed25519 key) and new username and saw that the DDB table was updated

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jun 13 2023, 10:15 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 13 2023, 10:15 PM

varun added a child revision: D8202: [keyserver] add removeReservedUsername method to rust-node-addon.Jun 13 2023, 10:16 PM

Harbormaster completed remote builds in B20231: Diff 27711.Jun 13 2023, 10:32 PM

varun requested review of this revision.Jun 13 2023, 10:32 PM

• jon accepted this revision.Jun 14 2023, 7:40 AM

This revision is now accepted and ready to land.Jun 14 2023, 7:40 AM

bartek accepted this revision.Jun 14 2023, 7:42 AM

rebase

rebase (properly, this time)

Harbormaster failed remote builds in B20298: Diff 27821!Jun 16 2023, 12:48 AM

Harbormaster completed remote builds in B20300: Diff 27823.Jun 16 2023, 1:21 AM

Closed by commit rCOMM32518a2bb167: [keyserver] add addReservedUsername method to rust-node-addon (authored by varun). · Explain WhyJun 22 2023, 1:30 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM32518a2bb167: [keyserver] add addReservedUsername method to rust-node-addon.

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

rust-node-addon/

rust-binding-types.js

1 line

src/

identity_client/

add_reserved_username.rs

23 lines

5 lines

Diff 28020

keyserver/addons/rust-node-addon/rust-binding-types.js

Loading...

keyserver/addons/rust-node-addon/src/identity_client/add_reserved_username.rs

Loading...

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

Loading...