Paths

Table of Contentst

[native] Introduce `NativeEditUserAvatarProvider`
ClosedPublic
Actions

Authored by atul on Jun 14 2023, 12:29 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMM9a1d07449411: [native] Introduce `NativeEditUserAvatarProvider`

Summary

Wraps BaseEditUserAvatarProvider and passes in native-specific props.

Sorry this diff is a little noisy, the main changes are in root.react.js and native-edit-thread-user-avatar-provider.react.js, rest are mostly import fixes.

Depends on D8216

Test Plan

Everything continues to work as expected on native.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 14 2023, 12:29 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 14 2023, 12:29 PM

reposition Props directly above component

atul published this revision for review.Jun 14 2023, 12:30 PM

atul added a child revision: D8218: [native] Pull `displayFailureAlert` out of `EditThreadAvatarProvider`.Jun 14 2023, 12:48 PM

Harbormaster completed remote builds in B20272: Diff 27789.Jun 14 2023, 12:49 PM

Harbormaster completed remote builds in B20273: Diff 27790.

ginsu accepted this revision.Jun 14 2023, 1:10 PM

This revision is now accepted and ready to land.Jun 14 2023, 1:10 PM

Closed by commit rCOMM9a1d07449411: [native] Introduce `NativeEditUserAvatarProvider` (authored by atul). · Explain WhyJun 14 2023, 2:22 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM9a1d07449411: [native] Introduce `NativeEditUserAvatarProvider`.

Revision Contents
Changeset List

Path

Size

lib/

components/

	base-edit-user-avatar-provider.react.js
	edit-user-avatar-provider.react.js

4 lines

edit-user-avatar-provider.react.js

native/

account/

registration/

avatar-selection.react.js

2 lines

emoji-avatar-selection.react.js

2 lines

registration-server-call.js

2 lines

avatars/

edit-user-avatar.react.js

2 lines

native-edit-user-avatar-provider.react.js

34 lines

media/

registration-user-avatar-camera-modal.react.js

2 lines

user-avatar-camera-modal.react.js

2 lines

profile/

emoji-user-avatar-creation.react.js

2 lines

root.react.js

24 lines

Diff 27790

View Options

lib/components/base-edit-user-avatar-provider.react.js

View Options

lib/components/edit-user-avatar-provider.react.js

View Options

native/account/registration/avatar-selection.react.js

View Options

native/account/registration/emoji-avatar-selection.react.js

View Options

native/account/registration/registration-server-call.js

View Options

native/avatars/edit-user-avatar.react.js

View Options

native/avatars/native-edit-user-avatar-provider.react.js

View Options

native/media/registration-user-avatar-camera-modal.react.js

View Options

native/media/user-avatar-camera-modal.react.js

View Options

native/profile/emoji-user-avatar-creation.react.js

View Options

[native] Introduce `NativeEditUserAvatarProvider`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27790

lib/components/base-edit-user-avatar-provider.react.js

lib/components/edit-user-avatar-provider.react.js

native/account/registration/avatar-selection.react.js

native/account/registration/emoji-avatar-selection.react.js

native/account/registration/registration-server-call.js

native/avatars/edit-user-avatar.react.js

native/avatars/native-edit-user-avatar-provider.react.js

native/media/registration-user-avatar-camera-modal.react.js

native/media/user-avatar-camera-modal.react.js

native/profile/emoji-user-avatar-creation.react.js

native/root.react.js

[native] Introduce `NativeEditUserAvatarProvider`
ClosedPublic
Actions

Revision Contents
Changeset List