[native] Pull `displayFailureAlert` out of `EditThreadAvatarProvider`
ClosedPublic
Actions

Authored by atul on Jun 14 2023, 12:48 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMMb1dc05e767fb: [native] Pull `displayFailureAlert` out of `EditThreadAvatarProvider`

Summary

Similar to D8213, but for thread avatars (changes aren't 1:1 for both providers so separated changes even if there's a little redundancy... also the diffs should be less noisy so easier to review?)

Depends on D8217 (kinda)

Test Plan

Killed keyserver and made sure alert appeared as expected.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 14 2023, 12:48 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 14 2023, 12:48 PM

atul published this revision for review.Jun 14 2023, 12:49 PM

atul added inline comments.

native/root.react.js
276–278	Again, I cluttered up `root.js` temporarily with all these props and then cleaned it up when I introduced `NativeEditThreadAvatarProvider` later in the stack