Page MenuHomePhabricator

[web] Change alert type in UserListItem
ClosedPublic

Authored by kuba on Jun 15 2023, 1:20 AM.
Tags
None
Referenced Files
F3488586: D8223.diff
Wed, Dec 18, 10:47 AM
Unknown Object (File)
Wed, Dec 4, 2:58 AM
Unknown Object (File)
Sat, Nov 23, 1:38 PM
Unknown Object (File)
Sat, Nov 23, 1:04 PM
Unknown Object (File)
Oct 26 2024, 11:43 PM
Unknown Object (File)
Oct 26 2024, 11:43 PM
Unknown Object (File)
Oct 26 2024, 11:43 PM
Unknown Object (File)
Oct 26 2024, 11:43 PM
Subscribers

Details

Summary

A new version of: https://phab.comm.dev/D5583 (to avoid rebasing problems).

Raised in D5518, it doesn't make sense for only one of alertText and alertTitle to be defined. This diff changes the type to make sure they are always defined together and updates the usages.

Test Plan

Checked for flow errors. Check if thread composer works correctly on web and native.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 15 2023, 8:31 AM