Page MenuHomePhabricator

[web] Change alert type in UserListItem
ClosedPublic

Authored by kuba on Jun 15 2023, 1:20 AM.
Tags
None
Referenced Files
F1787530: D8223.diff
Sat, May 18, 9:03 PM
Unknown Object (File)
Wed, May 15, 7:50 AM
Unknown Object (File)
Thu, May 9, 10:33 PM
Unknown Object (File)
Tue, May 7, 10:07 PM
Unknown Object (File)
Tue, May 7, 10:07 PM
Unknown Object (File)
Sat, May 4, 4:44 PM
Unknown Object (File)
Sat, May 4, 4:44 PM
Unknown Object (File)
Sat, May 4, 4:43 PM
Subscribers

Details

Summary

A new version of: https://phab.comm.dev/D5583 (to avoid rebasing problems).

Raised in D5518, it doesn't make sense for only one of alertText and alertTitle to be defined. This diff changes the type to make sure they are always defined together and updates the usages.

Test Plan

Checked for flow errors. Check if thread composer works correctly on web and native.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

This revision is now accepted and ready to land.Jun 15 2023, 8:31 AM