Page MenuHomePhabricator
Differential D8244

[services] Delete shared C++ lib
AbandonedPublic
Actions

Authored by bartek on Jun 19 2023, 4:01 AM.
Tags
None
Referenced Files
F5108740: D8244.diff
Tue, Apr 1, 3:00 PM
Unknown Object (File)
Fri, Mar 14, 5:06 AM
Unknown Object (File)
Mon, Mar 10, 8:09 PM
Unknown Object (File)
Mon, Mar 10, 8:09 PM
Unknown Object (File)
Mon, Mar 10, 7:56 PM
Unknown Object (File)
Mon, Mar 10, 7:49 PM
Unknown Object (File)
Mon, Mar 3, 7:59 PM
Unknown Object (File)
Feb 23 2025, 7:52 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
varun
atul
ashoat
Summary

Part of ENG-4098.
Deletes the services/lib directory which contained the shared C++ code.

Depends on D8230
old Tunnelbroker Dockerfile still required these files

Test Plan

CI, Tunnelbroker build should pass with D8230

Diff Detail

Repository
rCOMM Comm
Branch
barthap/remove-cpp-lib
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jun 19 2023, 4:01 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 19 2023, 4:01 AM
Harbormaster failed remote builds in B20320: Diff 27855!Jun 19 2023, 4:05 AM
bartek updated this revision to Diff 28219.Jun 28 2023, 12:05 PM

Rebase to fix CI

bartek published this revision for review.Jun 28 2023, 12:21 PM
Harbormaster completed remote builds in B20582: Diff 28219.Jun 28 2023, 12:22 PM
varun added a comment.Jun 28 2023, 12:25 PM

Ah, I didn't see this diff earlier and put out D8336

atul accepted this revision.Jun 28 2023, 12:25 PM
atul added a subscriber: atul.

Nice, no more reactors!

This revision is now accepted and ready to land.Jun 28 2023, 12:25 PM
bartek added a comment.Jun 28 2023, 12:28 PM
In D8244#246350, @varun wrote:

Ah, I didn't see this diff earlier and put out D8336

Your diff actually removes more stuff than mine

atul added a reviewer: ashoat. atul added 1 blocking reviewer(s): • jon.Jun 28 2023, 12:33 PM

Should've added @ashoat and @jon as blocking to take another look

This revision now requires review to proceed.Jun 28 2023, 12:33 PM
ashoat resigned from this revision.Jun 28 2023, 6:28 PM

I'm not super familiar with the services codebase

• jon accepted this revision.Jun 29 2023, 7:15 AM
This revision is now accepted and ready to land.Jun 29 2023, 7:15 AM
bartek abandoned this revision.Jun 29 2023, 8:25 AM

Replaced by D8336

Revision Contents
Changeset List

Diff 27855

View Options

services/lib/cmake-components/folly.cmake

Show First 20 Lines • Show All 65 Lines • ▼ Show 20 Lines
This runs the same two processes as the web app, but for the landing page. Note that the `landing.build.cjs` file (similar to the web app’s `app.build.cjs` file) is consumed by the Node server. This runs the same two processes as the web app, but for the landing page. Note that the `landing.build.cjs` file (similar to the web app’s `app.build.cjs` file) is consumed by the Node server.
# Debugging # Debugging
## React Developer Tools ## React Developer Tools
- For web, you can access the React Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Components” or “Profiler” tabs. This should work in both our development environment and in production. - For web, you can access the React Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Components” or “Profiler” tabs. This should work in both our development environment and in production.
- For iOS and Android, TODO - For iOS and Android, you can access the React Developer Tools by running `cd native && yarn react-devtools`. If you want to use it along with the JS debugger (see [Debugging JavaScript](#debugging-javascript)), you should open the JS debugger first, then open React Developer Tools, and finally refresh the app via the dev menu. More details on using React Developer Tools with React Native can be found [here](https://github.com/facebook/react/tree/main/packages/react-devtools#usage-with-react-native).
## Redux Developer Tools ## Redux Developer Tools
- For web, you can access the Redux Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Redux” tab. This should work in both our development environment and in production, although in production you won’t be able to see Redux actions from before you opened up the Redux dev tools. - For web, you can access the Redux Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Redux” tab. This should work in both our development environment and in production, although in production you won’t be able to see Redux actions from before you opened up the Redux dev tools.
- For iOS and Android, you can access the Redux Developer Tools through the Chrome extension’s Remote DevTools functionality. First, to open the Remote DevTools, right click on any webpage, go into the “Redux DevTools” menu, and select “Open Remote DevTools”. Then hit “Settings”, select “Use custom (local) server”, and configure it to connect to `localhost` on port 8043. This will connect to the `remotedev-server` instance that you started when you ran `cd native && yarn dev`. - For iOS and Android, you can access the Redux Developer Tools through the Chrome extension’s Remote DevTools functionality. First, to open the Remote DevTools, right click on any webpage, go into the “Redux DevTools” menu, and select “Open Remote DevTools”. Then hit “Settings”, select “Use custom (local) server”, and configure it to connect to `localhost` on port 8043. This will connect to the `remotedev-server` instance that you started when you ran `cd native && yarn dev`.
## Debugging JavaScript ## Debugging JavaScript
- For web, you can just use your browser of choice’s dev tools. - For web, you can just use your browser of choice’s dev tools.
- For iOS and Android, you can use the dev menu in dev builds to open up a JS debugger, where you can set breakpoints via the `debugger` expression. - For iOS and Android, you can use the dev menu in dev builds to open up a JS debugger, where you can set breakpoints via the `debugger` expression.
View Options

services/lib/cmake-components/grpc.cmake

Show First 20 Lines • Show All 65 Lines • ▼ Show 20 Lines
This runs the same two processes as the web app, but for the landing page. Note that the `landing.build.cjs` file (similar to the web app’s `app.build.cjs` file) is consumed by the Node server. This runs the same two processes as the web app, but for the landing page. Note that the `landing.build.cjs` file (similar to the web app’s `app.build.cjs` file) is consumed by the Node server.
# Debugging # Debugging
## React Developer Tools ## React Developer Tools
- For web, you can access the React Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Components” or “Profiler” tabs. This should work in both our development environment and in production. - For web, you can access the React Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Components” or “Profiler” tabs. This should work in both our development environment and in production.
- For iOS and Android, TODO - For iOS and Android, you can access the React Developer Tools by running `cd native && yarn react-devtools`. If you want to use it along with the JS debugger (see [Debugging JavaScript](#debugging-javascript)), you should open the JS debugger first, then open React Developer Tools, and finally refresh the app via the dev menu. More details on using React Developer Tools with React Native can be found [here](https://github.com/facebook/react/tree/main/packages/react-devtools#usage-with-react-native).
## Redux Developer Tools ## Redux Developer Tools
- For web, you can access the Redux Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Redux” tab. This should work in both our development environment and in production, although in production you won’t be able to see Redux actions from before you opened up the Redux dev tools. - For web, you can access the Redux Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Redux” tab. This should work in both our development environment and in production, although in production you won’t be able to see Redux actions from before you opened up the Redux dev tools.
- For iOS and Android, you can access the Redux Developer Tools through the Chrome extension’s Remote DevTools functionality. First, to open the Remote DevTools, right click on any webpage, go into the “Redux DevTools” menu, and select “Open Remote DevTools”. Then hit “Settings”, select “Use custom (local) server”, and configure it to connect to `localhost` on port 8043. This will connect to the `remotedev-server` instance that you started when you ran `cd native && yarn dev`. - For iOS and Android, you can access the Redux Developer Tools through the Chrome extension’s Remote DevTools functionality. First, to open the Remote DevTools, right click on any webpage, go into the “Redux DevTools” menu, and select “Open Remote DevTools”. Then hit “Settings”, select “Use custom (local) server”, and configure it to connect to `localhost` on port 8043. This will connect to the `remotedev-server` instance that you started when you ran `cd native && yarn dev`.
## Debugging JavaScript ## Debugging JavaScript
- For web, you can just use your browser of choice’s dev tools. - For web, you can just use your browser of choice’s dev tools.
- For iOS and Android, you can use the dev menu in dev builds to open up a JS debugger, where you can set breakpoints via the `debugger` expression. - For iOS and Android, you can use the dev menu in dev builds to open up a JS debugger, where you can set breakpoints via the `debugger` expression.
View Options

services/lib/docker/build_service.sh

Show First 20 Lines • Show All 65 Lines • ▼ Show 20 Lines
This runs the same two processes as the web app, but for the landing page. Note that the `landing.build.cjs` file (similar to the web app’s `app.build.cjs` file) is consumed by the Node server. This runs the same two processes as the web app, but for the landing page. Note that the `landing.build.cjs` file (similar to the web app’s `app.build.cjs` file) is consumed by the Node server.
# Debugging # Debugging
## React Developer Tools ## React Developer Tools
- For web, you can access the React Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Components” or “Profiler” tabs. This should work in both our development environment and in production. - For web, you can access the React Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Components” or “Profiler” tabs. This should work in both our development environment and in production.
- For iOS and Android, TODO - For iOS and Android, you can access the React Developer Tools by running `cd native && yarn react-devtools`. If you want to use it along with the JS debugger (see [Debugging JavaScript](#debugging-javascript)), you should open the JS debugger first, then open React Developer Tools, and finally refresh the app via the dev menu. More details on using React Developer Tools with React Native can be found [here](https://github.com/facebook/react/tree/main/packages/react-devtools#usage-with-react-native).
## Redux Developer Tools ## Redux Developer Tools
- For web, you can access the Redux Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Redux” tab. This should work in both our development environment and in production, although in production you won’t be able to see Redux actions from before you opened up the Redux dev tools. - For web, you can access the Redux Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Redux” tab. This should work in both our development environment and in production, although in production you won’t be able to see Redux actions from before you opened up the Redux dev tools.
- For iOS and Android, you can access the Redux Developer Tools through the Chrome extension’s Remote DevTools functionality. First, to open the Remote DevTools, right click on any webpage, go into the “Redux DevTools” menu, and select “Open Remote DevTools”. Then hit “Settings”, select “Use custom (local) server”, and configure it to connect to `localhost` on port 8043. This will connect to the `remotedev-server` instance that you started when you ran `cd native && yarn dev`. - For iOS and Android, you can access the Redux Developer Tools through the Chrome extension’s Remote DevTools functionality. First, to open the Remote DevTools, right click on any webpage, go into the “Redux DevTools” menu, and select “Open Remote DevTools”. Then hit “Settings”, select “Use custom (local) server”, and configure it to connect to `localhost` on port 8043. This will connect to the `remotedev-server` instance that you started when you ran `cd native && yarn dev`.
## Debugging JavaScript ## Debugging JavaScript
- For web, you can just use your browser of choice’s dev tools. - For web, you can just use your browser of choice’s dev tools.
- For iOS and Android, you can use the dev menu in dev builds to open up a JS debugger, where you can set breakpoints via the `debugger` expression. - For iOS and Android, you can use the dev menu in dev builds to open up a JS debugger, where you can set breakpoints via the `debugger` expression.
View Options

services/lib/docker/build_sources.sh

Show First 20 Lines • Show All 65 Lines • ▼ Show 20 Lines
This runs the same two processes as the web app, but for the landing page. Note that the `landing.build.cjs` file (similar to the web app’s `app.build.cjs` file) is consumed by the Node server. This runs the same two processes as the web app, but for the landing page. Note that the `landing.build.cjs` file (similar to the web app’s `app.build.cjs` file) is consumed by the Node server.
# Debugging # Debugging
## React Developer Tools ## React Developer Tools
- For web, you can access the React Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Components” or “Profiler” tabs. This should work in both our development environment and in production. - For web, you can access the React Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Components” or “Profiler” tabs. This should work in both our development environment and in production.
- For iOS and Android, TODO - For iOS and Android, you can access the React Developer Tools by running `cd native && yarn react-devtools`. If you want to use it along with the JS debugger (see [Debugging JavaScript](#debugging-javascript)), you should open the JS debugger first, then open React Developer Tools, and finally refresh the app via the dev menu. More details on using React Developer Tools with React Native can be found [here](https://github.com/facebook/react/tree/main/packages/react-devtools#usage-with-react-native).
## Redux Developer Tools ## Redux Developer Tools
- For web, you can access the Redux Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Redux” tab. This should work in both our development environment and in production, although in production you won’t be able to see Redux actions from before you opened up the Redux dev tools. - For web, you can access the Redux Developer Tools through the Chrome extension by opening the Chrome Developer Tools and selecting the “Redux” tab. This should work in both our development environment and in production, although in production you won’t be able to see Redux actions from before you opened up the Redux dev tools.
- For iOS and Android, you can access the Redux Developer Tools through the Chrome extension’s Remote DevTools functionality. First, to open the Remote DevTools, right click on any webpage, go into the “Redux DevTools” menu, and select “Open Remote DevTools”. Then hit “Settings”, select “Use custom (local) server”, and configure it to connect to `localhost` on port 8043. This will connect to the `remotedev-server` instance that you started when you ran `cd native && yarn dev`. - For iOS and Android, you can access the Redux Developer Tools through the Chrome extension’s Remote DevTools functionality. First, to open the Remote DevTools, right click on any webpage, go into the “Redux DevTools” menu, and select “Open Remote DevTools”. Then hit “Settings”, select “Use custom (local) server”, and configure it to connect to `localhost` on port 8043. This will connect to the `remotedev-server` instance that you started when you ran `cd native && yarn dev`.
## Debugging JavaScript ## Debugging JavaScript
- For web, you can just use your browser of choice’s dev tools. - For web, you can just use your browser of choice’s dev tools.
- For iOS and Android, you can use the dev menu in dev builds to open up a JS debugger, where you can set breakpoints via the `debugger` expression. - For iOS and Android, you can use the dev menu in dev builds to open up a JS debugger, where you can set breakpoints via the `debugger` expression.
View Options

services/lib/docker/install_corrosion.sh

Loading...
View Options

services/lib/docker/proto_codegen.sh

Loading...
View Options

services/lib/docker/run_service.sh

Loading...
View Options

services/lib/docker/run_tests.sh

Loading...
View Options

services/lib/src/BaseReactor.h

Loading...
View Options

services/lib/src/CMakeLists.txt

Loading...
View Options

services/lib/src/DatabaseEntitiesTools.h

Loading...
View Options

services/lib/src/DatabaseManagerBase.h

Loading...
View Options

services/lib/src/DatabaseManagerBase.cpp

Loading...
View Options

services/lib/src/DynamoDBTools.h

Loading...
View Options

services/lib/src/DynamoDBTools.cpp

Loading...
View Options

services/lib/src/GlobalConstants.h

Loading...
View Options

services/lib/src/GlobalTools.h

Loading...
View Options

services/lib/src/GlobalTools.cpp

Loading...
View Options

services/lib/src/Item.h

Loading...
View Options

services/lib/src/ReactorStatusHolder.h

Loading...
View Options

services/lib/src/ThreadPool.h

Loading...
View Options

services/lib/src/client-base-reactors/CMakeLists.txt

Loading...
View Options

services/lib/src/client-base-reactors/ClientBidiReactorBase.h

Loading...
View Options

services/lib/src/client-base-reactors/ClientReadReactorBase.h

Loading...
View Options

services/lib/src/client-base-reactors/ClientWriteReactorBase.h

Loading...
View Options

services/lib/src/server-base-reactors/CMakeLists.txt

Loading...
View Options

services/lib/src/server-base-reactors/ServerBidiReactorBase.h

Loading...
View Options

services/lib/src/server-base-reactors/ServerReadReactorBase.h

Loading...
View Options

services/lib/src/server-base-reactors/ServerWriteReactorBase.h

Loading...