Paths

Table of Contentst

[services] Delete shared C++ lib
AbandonedPublic
Actions

Authored by bartek on Jun 19 2023, 4:01 AM.

Details

Reviewers

• jon
varun
atul
ashoat

Summary

Part of ENG-4098.
Deletes the services/lib directory which contained the shared C++ code.

Depends on D8230
old Tunnelbroker Dockerfile still required these files

Test Plan

CI, Tunnelbroker build should pass with D8230

Diff Detail

Repository

rCOMM Comm

Branch

barthap/remove-cpp-lib

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jun 19 2023, 4:01 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 19 2023, 4:01 AM

Harbormaster failed remote builds in B20320: Diff 27855!Jun 19 2023, 4:05 AM

Rebase to fix CI

bartek published this revision for review.Jun 28 2023, 12:21 PM

Harbormaster completed remote builds in B20582: Diff 28219.Jun 28 2023, 12:22 PM

Ah, I didn't see this diff earlier and put out D8336

Nice, no more reactors!

This revision is now accepted and ready to land.Jun 28 2023, 12:25 PM

In D8244#246350, @varun wrote:

Ah, I didn't see this diff earlier and put out D8336

Your diff actually removes more stuff than mine

Should've added @ashoat and @jon as blocking to take another look

This revision now requires review to proceed.Jun 28 2023, 12:33 PM

I'm not super familiar with the services codebase

• jon accepted this revision.Jun 29 2023, 7:15 AM

This revision is now accepted and ready to land.Jun 29 2023, 7:15 AM

Replaced by D8336

Revision Contents
Changeset List

Path

Size

services/

lib/

cmake-components/

docker/

src/

DatabaseEntitiesTools.h

DatabaseManagerBase.h

DatabaseManagerBase.cpp

ReactorStatusHolder.h

ThreadPool.h

client-base-reactors/

CMakeLists.txt

ClientBidiReactorBase.h

ClientReadReactorBase.h

ClientWriteReactorBase.h

server-base-reactors/

CMakeLists.txt

ServerBidiReactorBase.h

ServerReadReactorBase.h

ServerWriteReactorBase.h

Diff 27855

View Options

services/lib/cmake-components/folly.cmake

View Options

services/lib/cmake-components/grpc.cmake

View Options

services/lib/docker/build_service.sh

View Options

services/lib/docker/build_sources.sh

View Options

services/lib/docker/install_corrosion.sh

View Options

services/lib/docker/proto_codegen.sh

View Options

services/lib/docker/run_service.sh

View Options

services/lib/docker/run_tests.sh

View Options

services/lib/src/BaseReactor.h

View Options

services/lib/src/CMakeLists.txt

View Options

services/lib/src/DatabaseEntitiesTools.h

View Options

services/lib/src/DatabaseManagerBase.h

View Options

services/lib/src/DatabaseManagerBase.cpp

View Options

services/lib/src/DynamoDBTools.h

View Options

services/lib/src/DynamoDBTools.cpp

View Options

services/lib/src/GlobalConstants.h

View Options

services/lib/src/GlobalTools.h

View Options

services/lib/src/GlobalTools.cpp

View Options

services/lib/src/Item.h

View Options

services/lib/src/ReactorStatusHolder.h

View Options

services/lib/src/ThreadPool.h

View Options

services/lib/src/client-base-reactors/CMakeLists.txt

View Options

services/lib/src/client-base-reactors/ClientBidiReactorBase.h

View Options

services/lib/src/client-base-reactors/ClientReadReactorBase.h

View Options

services/lib/src/client-base-reactors/ClientWriteReactorBase.h

View Options

services/lib/src/server-base-reactors/CMakeLists.txt

View Options

services/lib/src/server-base-reactors/ServerBidiReactorBase.h

View Options

services/lib/src/server-base-reactors/ServerReadReactorBase.h

View Options

services/lib/src/server-base-reactors/ServerWriteReactorBase.h

[services] Delete shared C++ libAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27855

services/lib/cmake-components/folly.cmake

services/lib/cmake-components/grpc.cmake

services/lib/docker/build_service.sh

services/lib/docker/build_sources.sh

services/lib/docker/install_corrosion.sh

services/lib/docker/proto_codegen.sh

services/lib/docker/run_service.sh

services/lib/docker/run_tests.sh

services/lib/src/BaseReactor.h

services/lib/src/CMakeLists.txt

services/lib/src/DatabaseEntitiesTools.h

services/lib/src/DatabaseManagerBase.h

services/lib/src/DatabaseManagerBase.cpp

services/lib/src/DynamoDBTools.h

services/lib/src/DynamoDBTools.cpp

services/lib/src/GlobalConstants.h

services/lib/src/GlobalTools.h

services/lib/src/GlobalTools.cpp

services/lib/src/Item.h

services/lib/src/ReactorStatusHolder.h

services/lib/src/ThreadPool.h

services/lib/src/client-base-reactors/CMakeLists.txt

services/lib/src/client-base-reactors/ClientBidiReactorBase.h

services/lib/src/client-base-reactors/ClientReadReactorBase.h

services/lib/src/client-base-reactors/ClientWriteReactorBase.h

services/lib/src/server-base-reactors/CMakeLists.txt

services/lib/src/server-base-reactors/ServerBidiReactorBase.h

services/lib/src/server-base-reactors/ServerReadReactorBase.h

services/lib/src/server-base-reactors/ServerWriteReactorBase.h

[services] Delete shared C++ lib
AbandonedPublic
Actions

Revision Contents
Changeset List