Page MenuHomePhabricator
Differential D8244

[services] Delete shared C++ lib
AbandonedPublic
Actions

Authored by bartek on Jun 19 2023, 4:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 14, 5:06 AM
Unknown Object (File)
Mon, Mar 10, 8:09 PM
Unknown Object (File)
Mon, Mar 10, 8:09 PM
Unknown Object (File)
Mon, Mar 10, 7:56 PM
Unknown Object (File)
Mon, Mar 10, 7:49 PM
Unknown Object (File)
Mon, Mar 3, 7:59 PM
Unknown Object (File)
Sun, Feb 23, 7:52 PM
Unknown Object (File)
Feb 18 2025, 4:05 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
varun
atul
ashoat
Summary

Part of ENG-4098.
Deletes the services/lib directory which contained the shared C++ code.

Depends on D8230
old Tunnelbroker Dockerfile still required these files

Test Plan

CI, Tunnelbroker build should pass with D8230

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jun 19 2023, 4:01 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 19 2023, 4:01 AM
Harbormaster failed remote builds in B20320: Diff 27855!Jun 19 2023, 4:05 AM
bartek updated this revision to Diff 28219.Jun 28 2023, 12:05 PM

Rebase to fix CI

bartek published this revision for review.Jun 28 2023, 12:21 PM
Harbormaster completed remote builds in B20582: Diff 28219.Jun 28 2023, 12:22 PM
varun added a comment.Jun 28 2023, 12:25 PM

Ah, I didn't see this diff earlier and put out D8336

atul accepted this revision.Jun 28 2023, 12:25 PM
atul added a subscriber: atul.

Nice, no more reactors!

This revision is now accepted and ready to land.Jun 28 2023, 12:25 PM
bartek added a comment.Jun 28 2023, 12:28 PM
In D8244#246350, @varun wrote:

Ah, I didn't see this diff earlier and put out D8336

Your diff actually removes more stuff than mine

atul added a reviewer: ashoat. atul added 1 blocking reviewer(s): • jon.Jun 28 2023, 12:33 PM

Should've added @ashoat and @jon as blocking to take another look

This revision now requires review to proceed.Jun 28 2023, 12:33 PM
ashoat resigned from this revision.Jun 28 2023, 6:28 PM

I'm not super familiar with the services codebase

• jon accepted this revision.Jun 29 2023, 7:15 AM
This revision is now accepted and ready to land.Jun 29 2023, 7:15 AM
bartek abandoned this revision.Jun 29 2023, 8:25 AM

Replaced by D8336

Revision Contents
Changeset List

Diff 28219

View Options

services/lib/cmake-components/folly.cmake

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
### Workflow specific prerequisites ### Workflow specific prerequisites
On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows. On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows.
- [Web prerequisites](./nix_web_setup.md#nix-web-requisities) - [Web prerequisites](./nix_web_setup.md#nix-web-requisities)
- [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension) - [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension)
- [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension) - [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites) - [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites)
- [iOS development](./nix_mobile_setup.md#ios-development) - [iOS development](./nix_mobile_setup.md#ios-development)
- [Xcode](./nix_mobile_setup.md#xcode) - [Xcode](./nix_mobile_setup.md#xcode)
- [Xcode settings](./nix_mobile_setup.md#xcode-settings) - [Xcode settings](./nix_mobile_setup.md#xcode-settings)
- [Android development](./nix_mobile_setup.md#android-development) - [Android development](./nix_mobile_setup.md#android-development)
- [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk) - [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk)
- [Android Studio](./nix_mobile_setup.md#android-studio) - [Android Studio](./nix_mobile_setup.md#android-studio)
- [Android SDK](./nix_mobile_setup.md#android-sdk) - [Android SDK](./nix_mobile_setup.md#android-sdk)
- [Android emulator](./nix_mobile_setup.md#android-emulator) - [Android emulator](./nix_mobile_setup.md#android-emulator)
- [Debugging tools](./nix_mobile_setup.md#debugging-tools) - [Debugging tools](./nix_mobile_setup.md#debugging-tools)
- [Homebrew](./nix_mobile_setup.md#homebrew) - [Homebrew](./nix_mobile_setup.md#homebrew)
- [Reactotron](./nix_mobile_setup.md#reactotron) - [Reactotron](./nix_mobile_setup.md#reactotron)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [idb (iOS Development Bridge)](./nix_mobile_setup.md#idb)
# Development environment # Development environment
Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites). Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites).
## Development workflows ## Development workflows
- [Web workflows](./nix_web_workflows.md#development) - [Web workflows](./nix_web_workflows.md#development)
Show All 27 Lines
View Options

services/lib/cmake-components/grpc.cmake

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
### Workflow specific prerequisites ### Workflow specific prerequisites
On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows. On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows.
- [Web prerequisites](./nix_web_setup.md#nix-web-requisities) - [Web prerequisites](./nix_web_setup.md#nix-web-requisities)
- [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension) - [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension)
- [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension) - [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites) - [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites)
- [iOS development](./nix_mobile_setup.md#ios-development) - [iOS development](./nix_mobile_setup.md#ios-development)
- [Xcode](./nix_mobile_setup.md#xcode) - [Xcode](./nix_mobile_setup.md#xcode)
- [Xcode settings](./nix_mobile_setup.md#xcode-settings) - [Xcode settings](./nix_mobile_setup.md#xcode-settings)
- [Android development](./nix_mobile_setup.md#android-development) - [Android development](./nix_mobile_setup.md#android-development)
- [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk) - [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk)
- [Android Studio](./nix_mobile_setup.md#android-studio) - [Android Studio](./nix_mobile_setup.md#android-studio)
- [Android SDK](./nix_mobile_setup.md#android-sdk) - [Android SDK](./nix_mobile_setup.md#android-sdk)
- [Android emulator](./nix_mobile_setup.md#android-emulator) - [Android emulator](./nix_mobile_setup.md#android-emulator)
- [Debugging tools](./nix_mobile_setup.md#debugging-tools) - [Debugging tools](./nix_mobile_setup.md#debugging-tools)
- [Homebrew](./nix_mobile_setup.md#homebrew) - [Homebrew](./nix_mobile_setup.md#homebrew)
- [Reactotron](./nix_mobile_setup.md#reactotron) - [Reactotron](./nix_mobile_setup.md#reactotron)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [idb (iOS Development Bridge)](./nix_mobile_setup.md#idb)
# Development environment # Development environment
Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites). Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites).
## Development workflows ## Development workflows
- [Web workflows](./nix_web_workflows.md#development) - [Web workflows](./nix_web_workflows.md#development)
Show All 27 Lines
View Options

services/lib/docker/build_service.sh

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
### Workflow specific prerequisites ### Workflow specific prerequisites
On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows. On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows.
- [Web prerequisites](./nix_web_setup.md#nix-web-requisities) - [Web prerequisites](./nix_web_setup.md#nix-web-requisities)
- [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension) - [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension)
- [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension) - [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites) - [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites)
- [iOS development](./nix_mobile_setup.md#ios-development) - [iOS development](./nix_mobile_setup.md#ios-development)
- [Xcode](./nix_mobile_setup.md#xcode) - [Xcode](./nix_mobile_setup.md#xcode)
- [Xcode settings](./nix_mobile_setup.md#xcode-settings) - [Xcode settings](./nix_mobile_setup.md#xcode-settings)
- [Android development](./nix_mobile_setup.md#android-development) - [Android development](./nix_mobile_setup.md#android-development)
- [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk) - [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk)
- [Android Studio](./nix_mobile_setup.md#android-studio) - [Android Studio](./nix_mobile_setup.md#android-studio)
- [Android SDK](./nix_mobile_setup.md#android-sdk) - [Android SDK](./nix_mobile_setup.md#android-sdk)
- [Android emulator](./nix_mobile_setup.md#android-emulator) - [Android emulator](./nix_mobile_setup.md#android-emulator)
- [Debugging tools](./nix_mobile_setup.md#debugging-tools) - [Debugging tools](./nix_mobile_setup.md#debugging-tools)
- [Homebrew](./nix_mobile_setup.md#homebrew) - [Homebrew](./nix_mobile_setup.md#homebrew)
- [Reactotron](./nix_mobile_setup.md#reactotron) - [Reactotron](./nix_mobile_setup.md#reactotron)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [idb (iOS Development Bridge)](./nix_mobile_setup.md#idb)
# Development environment # Development environment
Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites). Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites).
## Development workflows ## Development workflows
- [Web workflows](./nix_web_workflows.md#development) - [Web workflows](./nix_web_workflows.md#development)
Show All 27 Lines
View Options

services/lib/docker/build_sources.sh

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
### Workflow specific prerequisites ### Workflow specific prerequisites
On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows. On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows.
- [Web prerequisites](./nix_web_setup.md#nix-web-requisities) - [Web prerequisites](./nix_web_setup.md#nix-web-requisities)
- [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension) - [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension)
- [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension) - [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites) - [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites)
- [iOS development](./nix_mobile_setup.md#ios-development) - [iOS development](./nix_mobile_setup.md#ios-development)
- [Xcode](./nix_mobile_setup.md#xcode) - [Xcode](./nix_mobile_setup.md#xcode)
- [Xcode settings](./nix_mobile_setup.md#xcode-settings) - [Xcode settings](./nix_mobile_setup.md#xcode-settings)
- [Android development](./nix_mobile_setup.md#android-development) - [Android development](./nix_mobile_setup.md#android-development)
- [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk) - [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk)
- [Android Studio](./nix_mobile_setup.md#android-studio) - [Android Studio](./nix_mobile_setup.md#android-studio)
- [Android SDK](./nix_mobile_setup.md#android-sdk) - [Android SDK](./nix_mobile_setup.md#android-sdk)
- [Android emulator](./nix_mobile_setup.md#android-emulator) - [Android emulator](./nix_mobile_setup.md#android-emulator)
- [Debugging tools](./nix_mobile_setup.md#debugging-tools) - [Debugging tools](./nix_mobile_setup.md#debugging-tools)
- [Homebrew](./nix_mobile_setup.md#homebrew) - [Homebrew](./nix_mobile_setup.md#homebrew)
- [Reactotron](./nix_mobile_setup.md#reactotron) - [Reactotron](./nix_mobile_setup.md#reactotron)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [idb (iOS Development Bridge)](./nix_mobile_setup.md#idb)
# Development environment # Development environment
Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites). Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites).
## Development workflows ## Development workflows
- [Web workflows](./nix_web_workflows.md#development) - [Web workflows](./nix_web_workflows.md#development)
Show All 27 Lines
View Options

services/lib/docker/install_corrosion.sh

Loading...
View Options

services/lib/docker/proto_codegen.sh

Loading...
View Options

services/lib/docker/run_service.sh

Loading...
View Options

services/lib/docker/run_tests.sh

Loading...
View Options

services/lib/src/BaseReactor.h

Loading...
View Options

services/lib/src/CMakeLists.txt

Loading...
View Options

services/lib/src/DatabaseEntitiesTools.h

Loading...
View Options

services/lib/src/DatabaseManagerBase.h

Loading...
View Options

services/lib/src/DatabaseManagerBase.cpp

Loading...
View Options

services/lib/src/DynamoDBTools.h

Loading...
View Options

services/lib/src/DynamoDBTools.cpp

Loading...
View Options

services/lib/src/GlobalConstants.h

Loading...
View Options

services/lib/src/GlobalTools.h

Loading...
View Options

services/lib/src/GlobalTools.cpp

Loading...
View Options

services/lib/src/Item.h

Loading...
View Options

services/lib/src/ReactorStatusHolder.h

Loading...
View Options

services/lib/src/ThreadPool.h

Loading...
View Options

services/lib/src/client-base-reactors/CMakeLists.txt

Loading...
View Options

services/lib/src/client-base-reactors/ClientBidiReactorBase.h

Loading...
View Options

services/lib/src/client-base-reactors/ClientReadReactorBase.h

Loading...
View Options

services/lib/src/client-base-reactors/ClientWriteReactorBase.h

Loading...
View Options

services/lib/src/server-base-reactors/CMakeLists.txt

Loading...
View Options

services/lib/src/server-base-reactors/ServerBidiReactorBase.h

Loading...
View Options

services/lib/src/server-base-reactors/ServerReadReactorBase.h

Loading...
View Options

services/lib/src/server-base-reactors/ServerWriteReactorBase.h

Loading...