Page MenuHomePhabricator
Differential D8426

[dev-menu] Add Wipe Redux button to Expo dev menu
ClosedPublic
Actions

Authored by • patryk on Jul 5 2023, 1:47 AM.
Tags
None
Referenced Files
F3373884: D8426.diff
Tue, Nov 26, 12:26 PM
Unknown Object (File)
Wed, Nov 13, 1:46 PM
Unknown Object (File)
Wed, Nov 13, 1:46 PM
Unknown Object (File)
Wed, Nov 13, 1:46 PM
Unknown Object (File)
Wed, Nov 13, 1:46 PM
Unknown Object (File)
Wed, Nov 13, 1:46 PM
Unknown Object (File)
Wed, Nov 13, 1:45 PM
Unknown Object (File)
Oct 24 2024, 8:34 PM
View All 93 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
tomek
kamil
inka
Commits
rCOMM83e358936b6e: [dev-menu] Add Wipe Redux button to Expo dev menu
Summary

https://linear.app/comm/issue/ENG-2745/add-wipe-redux-button-to-expo-dev-menu.

Test Plan
  1. Run IOS sim
  2. Open Expo dev menu (cmd + ctrl + z)
  3. Press Wipe Redux button

Diff Detail

Repository
rCOMM Comm
Branch
patryk/dev-menu
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• patryk created this revision.Jul 5 2023, 1:47 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 5 2023, 1:47 AM
• patryk added reviewers: bartek, tomek, kamil, inka.Jul 5 2023, 1:48 AM
• patryk updated this revision to Diff 28396.Jul 5 2023, 1:58 AM

Remove unnecessary alert.

• patryk changed 2 blocking reviewer(s), added 1: kamil; removed 1: bartek.Jul 5 2023, 1:59 AM
Harbormaster completed remote builds in B20725: Diff 28395.Jul 5 2023, 2:04 AM
Harbormaster completed remote builds in B20726: Diff 28396.Jul 5 2023, 2:15 AM
• patryk requested review of this revision.Jul 5 2023, 2:15 AM
bartek accepted this revision.Jul 5 2023, 2:24 AM

Thanks for taking care of this! In some scenarios, this is a significant DX improvement.

To give more context: This is a useful feature in cases you break the app so badly that you cannot log in to enter the Profile -> Developer tools menu to kill the app. It happened to me sometimes when I messed up with the keyserver URL settings.
With this diff, you can shake the device (Ctrl+Cmd+Z in iOS simulator) or press the m key in Metro console to access this button.

native/dev-menu.js
27 ↗(On Diff #28396)

To match the button text from the Profile -> Developer tools menu and indicate that this kills the app ;)

• patryk updated this revision to Diff 28398.Jul 5 2023, 2:32 AM

Change button text.

• patryk changed 2 blocking reviewer(s), added 1: bartek; removed 1: kamil.Jul 5 2023, 2:32 AM
Harbormaster completed remote builds in B20727: Diff 28398.Jul 5 2023, 2:49 AM
kamil accepted this revision.Jul 5 2023, 2:50 AM
bartek accepted this revision.Jul 5 2023, 2:53 AM
This revision is now accepted and ready to land.Jul 5 2023, 2:53 AM
Closed by commit rCOMM83e358936b6e: [dev-menu] Add Wipe Redux button to Expo dev menu (authored by • patryk). · Explain WhyJul 5 2023, 3:02 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMM83e358936b6e: [dev-menu] Add Wipe Redux button to Expo dev menu.

Revision Contents
Changeset List

PathSize
native/
12 lines

Diff 28395

View Options

native/dev-menu.js

Loading...