Page MenuHomePhabricator
Differential D8447

[identity] hard-code the platform type for the identity docker image
ClosedPublic
Actions

Authored by varun on Jul 7 2023, 12:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 6:38 AM
Unknown Object (File)
Tue, Nov 19, 6:38 AM
Unknown Object (File)
Tue, Nov 19, 6:38 AM
Unknown Object (File)
Tue, Nov 19, 6:36 AM
Unknown Object (File)
Oct 29 2024, 8:21 PM
Unknown Object (File)
Oct 18 2024, 9:00 AM
Unknown Object (File)
Oct 18 2024, 9:00 AM
Unknown Object (File)
Oct 18 2024, 9:00 AM
View All 77 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMM911b16d1b973: [identity] hard-code the platform type for the identity docker image
Summary

On M1 Macs, the default image platform is arm64. We should build x86-64 images, though, since our EC2 instances are x86-64.

Test Plan

docker-compose build identity-server builds an x86-64 image on my M1 now

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Jul 7 2023, 12:54 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 7 2023, 12:54 PM
Harbormaster completed remote builds in B20810: Diff 28496.Jul 7 2023, 1:12 PM
varun requested review of this revision.Jul 7 2023, 1:12 PM
• jon accepted this revision.Jul 10 2023, 8:48 AM
This revision is now accepted and ready to land.Jul 10 2023, 8:48 AM
Closed by commit rCOMM911b16d1b973: [identity] hard-code the platform type for the identity docker image (authored by varun). · Explain WhyJul 10 2023, 10:04 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM911b16d1b973: [identity] hard-code the platform type for the identity docker image.
atul added a subscriber: atul.Jul 10 2023, 5:38 PM

Why not use arm64 instances? Are they more expensive? Vaguely recall the AWS Graviton instances having better price/performance?

varun added a comment.Jul 12 2023, 1:12 PM
In D8447#249659, @atul wrote:

Why not use arm64 instances? Are they more expensive? Vaguely recall the AWS Graviton instances having better price/performance?

i think graviton is only free-tier until the end of this year. if they extend it i'd be down to switch

Revision Contents
Changeset List

PathSize
services/
1 line

Diff 28556

View Options

services/docker-compose.yml

Loading...