[CI] Buildkite for web emscripten build
ClosedPublic
Actions

Authored by kamil on Jul 11 2023, 4:05 AM.

Details

Reviewers

michal
atul
• jon
bartek

Commits

rCOMM3ecc07921927: [CI] Buildkite for web emscripten build

Summary

Add a build to check if properly generated .wasm files are committed to repo.

Depends on D8446

Test Plan

Create new Buildkite pipeline: link.
Run new build and check if it passes: link to build.
Make some changes in CommQueryExecutor.cpp without generating new .wasm files, push it to branch and run new build, should fail: link to build.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 11 2023, 4:05 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 11 2023, 4:05 AM

kamil added 1 blocking reviewer(s): atul.Jul 11 2023, 4:06 AM

Harbormaster completed remote builds in B20862: Diff 28581.Jul 11 2023, 4:22 AM

kamil published this revision for review.Jul 12 2023, 6:09 AM

bartek accepted this revision.Jul 12 2023, 6:16 AM

ashoat added inline comments.Jul 12 2023, 9:40 AM

.buildkite/emscripten.yml
8 ↗	(On Diff #28581)	Why is this necessary?

• jon accepted this revision.Jul 14 2023, 3:11 PM

• jon added inline comments.

.buildkite/emscripten.yml
8 ↗	(On Diff #28581)	the autoscaling docker-based agents don't have nix installed

Looks good.

(It seems a little weird that we're checking the .wasm file into the repo since it feels like a build artifact like eg dev.build.js, but I'm sure there's a good reason)

This revision is now accepted and ready to land.Jul 16 2023, 11:24 PM

In D8469#250983, @atul wrote:

(It seems a little weird that we're checking the .wasm file into the repo since it feels like a build artifact like eg dev.build.js, but I'm sure there's a good reason)

The reason is described in ENG-4080.

Closed by commit rCOMM3ecc07921927: [CI] Buildkite for web emscripten build (authored by kamil). · Explain WhyJul 17 2023, 5:28 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM3ecc07921927: [CI] Buildkite for web emscripten build.