[lib] refactor Message Store Operations to use generic type
ClosedPublic
Actions

Authored by kamil on Jul 25 2023, 6:04 AM.

Details

Reviewers

michal
tomek
atul

Commits

rCOMM4fa884052ece: [lib] refactor Message Store Operations to use generic type

Summary

Make logic part of the general ops interface.

Note: Messages has a lot of different converters of a different types, so this could not be fitted in generic spec, so I chose the most general converter.

Depends on D8621

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 25 2023, 6:04 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 25 2023, 6:04 AM

Harbormaster failed remote builds in B21185: Diff 29019!Jul 25 2023, 6:19 AM

kamil retitled this revision from [lib] reactor Message Store Operations to use generic type to [lib] refactor Message Store Operations to use generic type.Jul 25 2023, 6:27 AM

kamil published this revision for review.Jul 25 2023, 6:35 AM

Harbormaster completed remote builds in B21185: Diff 29019.Jul 26 2023, 12:08 AM

atul accepted this revision.Jul 26 2023, 12:08 AM

This revision is now accepted and ready to land.Jul 26 2023, 12:08 AM

rename

Harbormaster completed remote builds in B21211: Diff 29048.Jul 26 2023, 3:19 AM

Closed by commit rCOMM4fa884052ece: [lib] refactor Message Store Operations to use generic type (authored by kamil). · Explain WhyJul 26 2023, 6:55 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM4fa884052ece: [lib] refactor Message Store Operations to use generic type.