[lib] refactor Thread Store Operations to use generic type
ClosedPublic
Actions

Authored by kamil on Jul 25 2023, 5:02 AM.

Details

Reviewers

michal
tomek
atul

Commits

rCOMMd6b30b24e82c: [lib] refactor Thread Store Operations to use generic type

Summary

Make logic part of the general ops interface

Depends on D8618

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 25 2023, 5:02 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 25 2023, 5:02 AM

Harbormaster completed remote builds in B21182: Diff 29015.Jul 25 2023, 5:38 AM

kamil added a child revision: D8621: [lib] refactor Report Store Operations to use generic type.Jul 25 2023, 6:01 AM

kamil retitled this revision from [lib] reactor Thread Store Operations to use generic type to [lib] refactor Thread Store Operations to use generic type.Jul 25 2023, 6:27 AM

kamil published this revision for review.Jul 25 2023, 6:35 AM

Consolidating ops-related code in lib/ops is a much cleaner way of organizing things

lib/reducers/thread-reducer.js
55 ↗	(On Diff #29015)	Wonder if there's a better way to name this so it's clear that this is an object w/ 3 methods and not the actual "ops"

This revision is now accepted and ready to land.Jul 26 2023, 12:04 AM

rename

lib/reducers/thread-reducer.js
55 ↗	(On Diff #29015)	good call, TBH I could find anything that will be 100% suitable but I'll update to `threadStoreOpsHandlers` - not ideal but better than `threadStoreOps`