[lib] refactor Report Store Operations to use generic type
ClosedPublic
Actions

Authored by kamil on Jul 25 2023, 6:01 AM.

Details

Reviewers

michal
tomek
atul

Commits

rCOMM23d408e3a6bf: [lib] refactor Report Store Operations to use generic type

Summary

Make logic part of the general ops interface

Depends on D8619

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 25 2023, 6:01 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 25 2023, 6:01 AM

kamil added a child revision: D8622: [lib] refactor Message Store Operations to use generic type.Jul 25 2023, 6:04 AM

Harbormaster completed remote builds in B21184: Diff 29018.Jul 25 2023, 6:18 AM

kamil retitled this revision from [lib] reactor Report Store Operations to use generic type to [lib] refactor Report Store Operations to use generic type.Jul 25 2023, 6:27 AM

kamil published this revision for review.Jul 25 2023, 6:35 AM

atul accepted this revision.Jul 26 2023, 12:07 AM

atul added inline comments.

lib/ops/report-store-ops.test.js
58 ↗	(On Diff #29018)	Still think we should call this `reportStoreOps` since the operations are related to how reports are stored and we're not "operating" on the reports themselves?