[Android] Remove 32-bit x86 support
ClosedPublic
Actions

Authored by atul on Jul 31 2023, 4:02 PM.

Details

Reviewers

ashoat
ginsu
• jon
marcin
tomek

Commits

rCOMM583c1520a50d: [Android] Remove 32-bit x86 support

Summary

Context: https://linear.app/comm/issue/ENG-4349/github-ci-for-android-appears-to-have-a-disk-space-issue

There are exceptionally few 32-bit x86 devices. By removing support for this architecture we can reduce disk usage and "fix" the GH Actions Android workflow. (There aren't a ton of 64-bit x86 devices either, but it's important to support that architecture for those using Android Emulator on Intel dev machines)

Depends on D8688

Test Plan

Android build succeeded on fork: https://github.com/atulsmadhugiri/comm/actions/runs/5719889594/job/15498728183

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jul 31 2023, 4:02 PM

atul published this revision for review.Jul 31 2023, 4:05 PM

atul added inline comments.

.github/workflows/android_ci.yml
23–27 ↗	(On Diff #29370)	Based on reading of "Maximize build disk space" action docs, there are two "disks": `/` `/mnt` and removing preinstalled software from `/` doesn't make a difference unless we: Concatenate the free space on / and /mnt (the temp disk) to an LVM volume group Create a swap partition and a build volume on that volume group Mount the build volume back to a given path (${GITHUB_WORKSPACE} by default) So going ahead and removing this step to simplify workflow for now.

atul edited the summary of this revision. (Show Details)Jul 31 2023, 4:09 PM

atul added a parent revision: D8688: [GH Actions] Remove JDK 11 step from Android workflows.

atul added a child revision: D8690: [GH Actions] Add "Disk Usage" step to Android workflows.Jul 31 2023, 4:09 PM

Harbormaster completed remote builds in B21442: Diff 29370.Aug 1 2023, 12:20 AM

ashoat accepted this revision.Aug 1 2023, 5:29 AM

ashoat added inline comments.

.github/workflows/android_ci.yml
23–27 ↗	(On Diff #29370)	Hmmm, does that not contradict what GitHub staff are saying on this issue?

This revision is now accepted and ready to land.Aug 1 2023, 5:29 AM

atul added inline comments.Aug 1 2023, 1:21 PM

.github/workflows/android_ci.yml
23–27 ↗	(On Diff #29370)	Yeah, that threw me off as well. My best guess is that the info in that comment is out-of-date?
23–27 ↗	(On Diff #29370)	Hm, seemed to work for these people yesterday: https://github.com/hvgazula/build_docker/pull/2