Page MenuHomePhabricator

[keyserver] Stop sending incorrect macOS rescinds
ClosedPublic

Authored by michal on Aug 1 2023, 8:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 30, 5:29 PM
Unknown Object (File)
Thu, Jun 13, 12:09 AM
Unknown Object (File)
May 19 2024, 1:49 AM
Unknown Object (File)
May 7 2024, 10:16 PM
Unknown Object (File)
May 7 2024, 10:16 PM
Unknown Object (File)
May 7 2024, 10:16 PM
Unknown Object (File)
May 7 2024, 10:16 PM
Unknown Object (File)
May 4 2024, 5:06 PM
Subscribers

Details

Summary

ENG-4523

Because of handling of older deliveries with only iosID, and because we were always setting parsedDeliveries' platform to 'ios' we were incorrectly trying to send rescinds for macOS notifications. This diff makes it so we are setting the platform correctly, and the parsed deliveries for macos are filtered later in the code.

Test Plan
  • Check that after displaying a notification no rescinds for macOS are sent

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable