Paths

Table of Contentst

Differential D8699

[keyserver] Stop sending incorrect macOS rescinds
ClosedPublic
Actions

Authored by michal on Aug 1 2023, 8:53 AM.

Tags

None

Referenced Files

	F2197522: D8699.diff
	Fri, Jul 5, 3:09 PM

	F2194862: D8699.diff
	Fri, Jul 5, 8:20 AM

	Unknown Object (File)
	Thu, Jul 4, 10:42 AM

	Unknown Object (File)
	Thu, Jul 4, 9:48 AM

	Unknown Object (File)
	Sun, Jun 30, 5:29 PM

	Unknown Object (File)
	Thu, Jun 13, 12:09 AM

	Unknown Object (File)
	May 19 2024, 1:49 AM

	Unknown Object (File)
	May 7 2024, 10:16 PM

View All 58 Files

Subscribers

Details

Reviewers

kamil
tomek
marcin
ashoat

Commits

rCOMM7df79984aa92: [keyserver] Stop sending incorrect macOS rescinds

Summary

Because of handling of older deliveries with only iosID, and because we were always setting parsedDeliveries' platform to 'ios' we were incorrectly trying to send rescinds for macOS notifications. This diff makes it so we are setting the platform correctly, and the parsed deliveries for macos are filtered later in the code.

Test Plan

Check that after displaying a notification no rescinds for macOS are sent

Diff Detail

Repository

Branch

michal/eng-4523

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Aug 1 2023, 8:53 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 1 2023, 8:53 AM

michal added inline comments.Aug 1 2023, 8:54 AM

keyserver/src/push/rescind.js
73	Not strictly needed, but probably better to be explicit

Harbormaster completed remote builds in B21467: Diff 29445.Aug 1 2023, 9:56 AM

michal requested review of this revision.Aug 1 2023, 9:56 AM

ashoat accepted this revision.Aug 1 2023, 10:56 AM

This revision is now accepted and ready to land.Aug 1 2023, 10:56 AM

Closed by commit rCOMM7df79984aa92: [keyserver] Stop sending incorrect macOS rescinds (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyAug 2 2023, 2:04 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM7df79984aa92: [keyserver] Stop sending incorrect macOS rescinds.

michal mentioned this in D8705: [keyserver] Update type for platform in ParsedDelivery.Aug 2 2023, 8:45 AM

Michal Gniadek <michal.gniadek@swmansion.com> mentioned this in rCOMM12b81158f886: [keyserver] Update type for platform in ParsedDelivery.Aug 4 2023, 6:07 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

8 lines

Diff 29445

keyserver/src/push/rescind.js

Loading...