Page MenuHomePhabricator
Differential D8712

[terraform] Dont load-balance EC2 services in staging
ClosedPublic
Actions

Authored by bartek on Aug 3 2023, 2:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 11:41 PM
Unknown Object (File)
Tue, Nov 19, 5:47 AM
Unknown Object (File)
Sun, Nov 17, 3:50 AM
Unknown Object (File)
Sun, Nov 17, 3:50 AM
Unknown Object (File)
Sun, Nov 17, 3:48 AM
Unknown Object (File)
Sat, Nov 16, 11:28 PM
Unknown Object (File)
Thu, Nov 14, 2:31 AM
Unknown Object (File)
Oct 17 2024, 1:06 AM
View All 66 Files
Subscribers
ashoat
tomek

Details

Reviewers
• jon
varun
Commits
rCOMM4f22ae24f859: [terraform] Dont load-balance EC2 services in staging
Summary

This stack resolves issues encountered when setting up fresh staging AWS account with Terraform.

On staging we don't have legacy EC2 services, so these data blocks errored because couldn't find them.
Made them conditional.
Task for deleting legacy EC2 instances: ENG-4543 - worth doing later after everything is confirmed to be working.

Test Plan

terraform plan for production doesn't change anything, for staging it doesn't error.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Aug 3 2023, 2:17 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 3 2023, 2:17 AM
bartek added a child revision: D8713: [terraform] Use subdomain for staging services.Aug 3 2023, 2:19 AM
Harbormaster failed remote builds in B21503: Diff 29500!Aug 3 2023, 2:43 AM
bartek published this revision for review.Aug 3 2023, 2:48 AM
bartek added inline comments.
services/terraform/remote/main.tf
19 ↗(On Diff #29500)

I find this helper variable very handy

varun accepted this revision.Aug 4 2023, 12:07 PM
This revision is now accepted and ready to land.Aug 4 2023, 12:07 PM
This revision was landed with ongoing or failed builds.Aug 8 2023, 12:19 PM
Closed by commit rCOMM4f22ae24f859: [terraform] Dont load-balance EC2 services in staging (authored by bartek). · Explain Why
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM4f22ae24f859: [terraform] Dont load-balance EC2 services in staging.

Revision Contents
Changeset List

PathSize
services/
terraform/
remote/
4 lines
13 lines
13 lines
13 lines
13 lines

Diff 29662

View Options

services/terraform/remote/main.tf

Loading...
View Options

services/terraform/remote/service_blob.tf

Loading...
View Options

services/terraform/remote/service_electron_update.tf

Loading...
View Options

services/terraform/remote/service_feature_flags.tf

Loading...
View Options

services/terraform/remote/service_identity.tf

Loading...