Page MenuHomePhabricator

[blob-service] Make S3 bucket configurable
ClosedPublic

Authored by bartek on Aug 6 2023, 7:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 24, 10:42 AM
Unknown Object (File)
Mon, May 13, 10:15 AM
Unknown Object (File)
Tue, May 7, 9:12 PM
Unknown Object (File)
Tue, May 7, 9:12 PM
Unknown Object (File)
Tue, May 7, 9:12 PM
Unknown Object (File)
Tue, May 7, 9:10 PM
Unknown Object (File)
Mar 27 2024, 11:55 PM
Unknown Object (File)
Feb 24 2024, 11:25 AM
Subscribers

Details

Summary

Part of ENG-4573. Added a new --s3-bucket-name CLI option and BLOB_S3_BUCKET_NAME environment variable that allows to override the default commapp-blob S3 bucket. We need this to be able to use a separate bucket in staging environment.

Test Plan

Ran integration tests locally - confirmed that default S3 bucket is used. Ran integration tests with --s3-bucket-name set to non-existent bucket - they fail with NoSuchBucketError as expected. Repeated with the environment variable set instead.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable