Page MenuHomePhabricator

[blob-service] Make S3 bucket configurable
ClosedPublic

Authored by bartek on Aug 6 2023, 7:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 3:05 AM
Unknown Object (File)
Sun, Nov 17, 3:05 AM
Unknown Object (File)
Sun, Nov 17, 2:59 AM
Unknown Object (File)
Sat, Nov 16, 11:28 PM
Unknown Object (File)
Oct 17 2024, 1:06 AM
Unknown Object (File)
Oct 17 2024, 1:06 AM
Unknown Object (File)
Oct 17 2024, 1:02 AM
Unknown Object (File)
Oct 16 2024, 11:40 PM
Subscribers

Details

Summary

Part of ENG-4573. Added a new --s3-bucket-name CLI option and BLOB_S3_BUCKET_NAME environment variable that allows to override the default commapp-blob S3 bucket. We need this to be able to use a separate bucket in staging environment.

Test Plan

Ran integration tests locally - confirmed that default S3 bucket is used. Ran integration tests with --s3-bucket-name set to non-existent bucket - they fail with NoSuchBucketError as expected. Repeated with the environment variable set instead.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable