Page MenuHomePhabricator
Differential D8742

[blob-service] Make S3 bucket configurable
ClosedPublic
Actions

Authored by bartek on Aug 6 2023, 7:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 18, 1:21 PM
Unknown Object (File)
Feb 23 2025, 1:50 AM
Unknown Object (File)
Feb 23 2025, 1:50 AM
Unknown Object (File)
Feb 23 2025, 1:46 AM
Unknown Object (File)
Feb 23 2025, 12:39 AM
Unknown Object (File)
Jan 20 2025, 6:59 PM
Unknown Object (File)
Jan 20 2025, 6:59 PM
Unknown Object (File)
Jan 20 2025, 6:58 PM
View All 73 Files
Subscribers
ashoat
tomek

Details

Reviewers
• jon
varun
michal
Commits
rCOMMf43e384dda7f: [blob-service] Make S3 bucket configurable
Summary

Part of ENG-4573. Added a new --s3-bucket-name CLI option and BLOB_S3_BUCKET_NAME environment variable that allows to override the default commapp-blob S3 bucket. We need this to be able to use a separate bucket in staging environment.

Test Plan

Ran integration tests locally - confirmed that default S3 bucket is used. Ran integration tests with --s3-bucket-name set to non-existent bucket - they fail with NoSuchBucketError as expected. Repeated with the environment variable set instead.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
blob/
src/
10 lines
3 lines
database/
7 lines
7 lines

Diff 29630

View Options

services/blob/src/config.rs

Show All 10 Lines
div.messageActionContainer { div.messageActionContainer {
display: flex; display: flex;
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
border-radius: 8px; border-radius: 8px;
width: fit-content; width: fit-content;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.messageActionButtons { div.messageActionButtons {
display: flex; display: flex;
font-size: 16px; font-size: 16px;
} }
div.messageActionButtons svg { div.messageActionButtons svg {
padding: 10px 6px 6px; padding: 10px 6px 6px;
Show All 17 Linesdiv.messageTooltipLabel {
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
color: var(--tool-tip-color); color: var(--tool-tip-color);
border-radius: 8px; border-radius: 8px;
overflow: auto; overflow: auto;
white-space: nowrap; white-space: nowrap;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.leftTooltipAlign { div.leftTooltipAlign {
align-items: flex-start; align-items: flex-start;
} }
div.centerTooltipAlign { div.centerTooltipAlign {
align-items: center; align-items: center;
Show All 10 Lines
View Options

services/blob/src/constants.rs

Show All 10 Lines
div.messageActionContainer { div.messageActionContainer {
display: flex; display: flex;
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
border-radius: 8px; border-radius: 8px;
width: fit-content; width: fit-content;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.messageActionButtons { div.messageActionButtons {
display: flex; display: flex;
font-size: 16px; font-size: 16px;
} }
div.messageActionButtons svg { div.messageActionButtons svg {
padding: 10px 6px 6px; padding: 10px 6px 6px;
Show All 17 Linesdiv.messageTooltipLabel {
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
color: var(--tool-tip-color); color: var(--tool-tip-color);
border-radius: 8px; border-radius: 8px;
overflow: auto; overflow: auto;
white-space: nowrap; white-space: nowrap;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.leftTooltipAlign { div.leftTooltipAlign {
align-items: flex-start; align-items: flex-start;
} }
div.centerTooltipAlign { div.centerTooltipAlign {
align-items: center; align-items: center;
Show All 10 Lines
View Options

services/blob/src/database/old.rs

Show All 10 Lines
div.messageActionContainer { div.messageActionContainer {
display: flex; display: flex;
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
border-radius: 8px; border-radius: 8px;
width: fit-content; width: fit-content;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.messageActionButtons { div.messageActionButtons {
display: flex; display: flex;
font-size: 16px; font-size: 16px;
} }
div.messageActionButtons svg { div.messageActionButtons svg {
padding: 10px 6px 6px; padding: 10px 6px 6px;
Show All 17 Linesdiv.messageTooltipLabel {
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
color: var(--tool-tip-color); color: var(--tool-tip-color);
border-radius: 8px; border-radius: 8px;
overflow: auto; overflow: auto;
white-space: nowrap; white-space: nowrap;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.leftTooltipAlign { div.leftTooltipAlign {
align-items: flex-start; align-items: flex-start;
} }
div.centerTooltipAlign { div.centerTooltipAlign {
align-items: center; align-items: center;
Show All 10 Lines
View Options

services/blob/src/database/types.rs

Show All 10 Lines
div.messageActionContainer { div.messageActionContainer {
display: flex; display: flex;
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
border-radius: 8px; border-radius: 8px;
width: fit-content; width: fit-content;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.messageActionButtons { div.messageActionButtons {
display: flex; display: flex;
font-size: 16px; font-size: 16px;
} }
div.messageActionButtons svg { div.messageActionButtons svg {
padding: 10px 6px 6px; padding: 10px 6px 6px;
Show All 17 Linesdiv.messageTooltipLabel {
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
color: var(--tool-tip-color); color: var(--tool-tip-color);
border-radius: 8px; border-radius: 8px;
overflow: auto; overflow: auto;
white-space: nowrap; white-space: nowrap;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.leftTooltipAlign { div.leftTooltipAlign {
align-items: flex-start; align-items: flex-start;
} }
div.centerTooltipAlign { div.centerTooltipAlign {
align-items: center; align-items: center;
Show All 10 Lines