Page MenuHomePhabricator

[blob-service] Make S3 bucket configurable
ClosedPublic

Authored by bartek on Aug 6 2023, 7:53 AM.
Tags
None
Referenced Files
F2114296: D8742.id29630.diff
Wed, Jun 26, 5:23 AM
F2113810: D8742.id29569.diff
Wed, Jun 26, 4:19 AM
Unknown Object (File)
Fri, Jun 21, 10:24 AM
Unknown Object (File)
Wed, Jun 19, 3:24 AM
Unknown Object (File)
Wed, Jun 19, 2:25 AM
Unknown Object (File)
Mon, Jun 17, 4:57 AM
Unknown Object (File)
Tue, Jun 11, 5:39 PM
Unknown Object (File)
Wed, Jun 5, 11:50 PM
Subscribers

Details

Summary

Part of ENG-4573. Added a new --s3-bucket-name CLI option and BLOB_S3_BUCKET_NAME environment variable that allows to override the default commapp-blob S3 bucket. We need this to be able to use a separate bucket in staging environment.

Test Plan

Ran integration tests locally - confirmed that default S3 bucket is used. Ran integration tests with --s3-bucket-name set to non-existent bucket - they fail with NoSuchBucketError as expected. Repeated with the environment variable set instead.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable