From the device_info HashMap, we need to construct an InboundKeyInfo struct. These are some helper functions to do that.
Depends on D8761
Details
Details
- Reviewers
• jon bartek - Commits
- rCOMMe1591be9eb39: [identity] more helpers for identity service
Tested in subsequent diff when we actually call the helpers
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- getInboundKeysForUser (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/identity/src/client_service.rs | ||
|---|---|---|
| 897–901 | This file is already ~1000 lines long. Do you mind if we have a grpc_utils.rs, which contains all these "marshaling to types" helpers? Also, we might be able to do impl TryFrom<HashMap<String, String>> for InboundKeyInfo, which would just make the call into: let inbound_key_info = InboundKeyInfo::try_from(query)?; | |
| 931–934 | In D8607 I added something similar | |
| services/identity/src/client_service.rs | ||
|---|---|---|
| 931–934 | I couldn't find the method you added... | |
| services/identity/src/grpc_utils.rs | ||
|---|---|---|
| 26 ↗ | (On Diff #30059) | this should just be impl actually, not impl<'a>. I have fixed it in the subsequent diff |
| services/identity/src/client_service.rs | ||
|---|---|---|
| 931–934 | the trait implementation is HashMap<String, AttributeValue> but the type I'm dealing with here is HashMap<String, String> | |