Page MenuHomePhabricator

[web] Introduce barebones `EditThreadAvatarMenu`
ClosedPublic

Authored by atul on Aug 16 2023, 5:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 3, 12:24 AM
Unknown Object (File)
Sat, Sep 14, 3:34 AM
Unknown Object (File)
Sat, Sep 14, 3:34 AM
Unknown Object (File)
Sat, Sep 14, 3:34 AM
Unknown Object (File)
Sat, Sep 14, 3:34 AM
Unknown Object (File)
Sat, Sep 14, 3:30 AM
Unknown Object (File)
Thu, Sep 5, 4:47 AM
Unknown Object (File)
Wed, Sep 4, 8:57 PM
Subscribers

Details

Summary

Similar to EditUserAvatarMenu, but for threads.

This diff only introduces the "Reset to default" functionality. Next diff will add image avatar support. The diff after that will add emoji support.

Test Plan
  1. Set thread avatar
  2. Press "Reset to default" button and observe that thread avatar is unset in DB

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Aug 16 2023, 5:31 PM
atul added inline comments.
web/components/menu.react.js
119 ↗(On Diff #29984)

Otherwise button defaults to submit behavior when nested within form

web/avatars/edit-thread-avatar-menu.react.js
14–18 ↗(On Diff #29984)

Yeah, this is basically cut/paste from EditUserAvatarMenu. Will factor out as part of refactors later in stack (they're minimal)

Code looks good, it would be helpful to get a screenshot of EditThreadAvatarMenu even if it's barebones since we are introducing the component here

This revision is now accepted and ready to land.Aug 17 2023, 11:20 AM
This revision was landed with ongoing or failed builds.Aug 18 2023, 1:48 PM
This revision was automatically updated to reflect the committed changes.