Page MenuHomePhabricator
Differential D8840

[web] Introduce barebones `EditThreadAvatarMenu`
ClosedPublic
Actions

Authored by atul on Aug 16 2023, 5:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 28, 1:45 PM
Unknown Object (File)
Mon, Oct 28, 1:45 PM
Unknown Object (File)
Mon, Oct 28, 1:45 PM
Unknown Object (File)
Mon, Oct 28, 1:45 PM
Unknown Object (File)
Mon, Oct 28, 1:43 PM
Unknown Object (File)
Oct 4 2024, 10:21 PM
Unknown Object (File)
Oct 4 2024, 10:19 PM
Unknown Object (File)
Oct 4 2024, 8:18 PM
View All 73 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM8ef452196091: [web] Introduce barebones `EditThreadAvatarMenu`
Summary

Similar to EditUserAvatarMenu, but for threads.

This diff only introduces the "Reset to default" functionality. Next diff will add image avatar support. The diff after that will add emoji support.

Test Plan
  1. Set thread avatar
  2. Press "Reset to default" button and observe that thread avatar is unset in DB

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Aug 16 2023, 5:30 PM
Herald added a subscriber: tomek. · View Herald TranscriptAug 16 2023, 5:30 PM
atul published this revision for review.Aug 16 2023, 5:31 PM
atul added inline comments.
web/components/menu.react.js
119 ↗(On Diff #29984)

Otherwise button defaults to submit behavior when nested within form

atul added inline comments.Aug 16 2023, 5:34 PM
web/avatars/edit-thread-avatar-menu.react.js
14–18 ↗(On Diff #29984)

Yeah, this is basically cut/paste from EditUserAvatarMenu. Will factor out as part of refactors later in stack (they're minimal)

Harbormaster completed remote builds in B21813: Diff 29984.Aug 16 2023, 5:50 PM
atul added a child revision: D8841: [web] Add image avatar support to `EditThreadAvatarMenu`.Aug 16 2023, 7:12 PM
ginsu accepted this revision.Aug 17 2023, 11:20 AM

Code looks good, it would be helpful to get a screenshot of EditThreadAvatarMenu even if it's barebones since we are introducing the component here

This revision is now accepted and ready to land.Aug 17 2023, 11:20 AM
ginsu mentioned this in D8841: [web] Add image avatar support to `EditThreadAvatarMenu`.Aug 17 2023, 12:58 PM
atul updated this revision to Diff 30090.Aug 18 2023, 1:43 PM

rebase and land

This revision was landed with ongoing or failed builds.Aug 18 2023, 1:48 PM
Closed by commit rCOMM8ef452196091: [web] Introduce barebones `EditThreadAvatarMenu` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM8ef452196091: [web] Introduce barebones `EditThreadAvatarMenu`.
Harbormaster completed remote builds in B21904: Diff 30090.Aug 18 2023, 2:04 PM

Revision Contents
Changeset List

Diff 30091

View Options

web/avatars/edit-avatar-menu.css

Loading...
View Options

web/avatars/edit-thread-avatar-menu.react.js

Loading...
View Options

web/avatars/edit-thread-avatar.react.js

Loading...
View Options

web/avatars/edit-user-avatar-menu.css

Loading...
View Options

web/avatars/edit-user-avatar-menu.react.js

Loading...
View Options

web/components/menu.react.js

Loading...