Page MenuHomePhabricator

[web] Introduce `UserEmojiAvatarSelectionModal` component
ClosedPublic

Authored by atul on Aug 17 2023, 1:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 3:58 PM
Unknown Object (File)
Tue, Nov 5, 2:12 AM
Unknown Object (File)
Oct 7 2024, 8:21 PM
Unknown Object (File)
Oct 6 2024, 7:30 PM
Subscribers

Details

Summary

The EmojiAvatarSelectionModal component was user avatar specific. In this diff we "lift" user avatar-specific logic to UserEmojiAvatarSelectionModal and make EmojiAvatarSelectionModal user/thread-avatar agnostic.

The "API" for EmojiAvatarSelectionModal will be the currentAvatar, defaultAvatar, setEmojiAvatar, and avatarSaveInProgress props. This should allow maximal reuse of EmojiAvatarSelectionModal component.


Depends on D8854

Test Plan

Setting user emoji avatar continues working as expected/before.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Aug 17 2023, 1:04 PM
atul edited the test plan for this revision. (Show Details)

Not looking too closely, but it seems okay

This revision is now accepted and ready to land.Aug 18 2023, 3:46 PM
This revision was landed with ongoing or failed builds.Aug 21 2023, 4:17 PM
This revision was automatically updated to reflect the committed changes.