[web] Introduce `ThreadEmojiAvatarSelectionModal`
ClosedPublic
Actions

Authored by atul on Aug 17 2023, 1:30 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMM28b1e5133218: [web] Introduce `ThreadEmojiAvatarSelectionModal`

Summary

Enables setting of emoji avatars on web. As of this diff all varieties of thread avatar can be set from web. We just need to make a few layout tweaks in ThreadSettingsModalGeneralTab in order to get this ready to ship.

Depends on D8855

Test Plan

Works as expected:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Aug 17 2023, 1:30 PM

Herald added a subscriber: tomek. · View Herald TranscriptAug 17 2023, 1:30 PM

atul published this revision for review.Aug 17 2023, 1:30 PM

atul edited the summary of this revision. (Show Details)

atul added a parent revision: D8855: [web] Introduce `UserEmojiAvatarSelectionModal` component.

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B21868: Diff 30046.Aug 17 2023, 1:51 PM

Not looking too closely

web/avatars/thread-emoji-avatar-selection-modal.react.js
38–40 ↗	(On Diff #30046)	Do you really need `async` / `await` here? Can you just forward the promise? If not, can you update the Flow type for the props of `EmojiAvatarSelectionModal` so that it's flexible (eg. `Promise<mixed>`), and then forward the promise?