[web] Add image avatar support to `EditThreadAvatarMenu`
ClosedPublic
Actions

Authored by atul on Aug 16 2023, 7:12 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMM447c68cc6a72: [web] Add image avatar support to `EditThreadAvatarMenu`

Summary

Allows setting of image avatars on web.

Depends on D8840

Test Plan

Works as expected:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Aug 16 2023, 7:12 PM

Herald added a subscriber: tomek. · View Herald TranscriptAug 16 2023, 7:12 PM

atul published this revision for review.Aug 16 2023, 7:14 PM

atul edited the test plan for this revision. (Show Details)

atul added a child revision: D8842: [web] Fix filename typo.Aug 16 2023, 7:18 PM

Harbormaster completed remote builds in B21814: Diff 29985.Aug 16 2023, 7:31 PM

LGTM, also you can disregard my comment on D8840 since there is a screenshot/demo here to watch.

Also, this is outside the scope of this diff, but I think a better UI/UX would be to make the whole Edit Avatar component here clickable instead of just the badge.
cc @ted

ginsu accepted this revision.Aug 17 2023, 12:58 PM

This revision is now accepted and ready to land.Aug 17 2023, 12:58 PM

Also, this is outside the scope of this diff, but I think a better UI/UX would be to make the whole Edit Avatar component here clickable instead of just the badge.

cc @ted

Landing, will message @ted w/ direct link to comment