Page MenuHomePhabricator
Differential D8879

[lib] Move conversion function out of validation utils
ClosedPublic
Actions

Authored by michal on Aug 21 2023, 1:48 AM.
Tags
None
Referenced Files
F3369876: D8879.diff
Mon, Nov 25, 11:50 PM
Unknown Object (File)
Wed, Nov 20, 5:40 PM
Unknown Object (File)
Wed, Nov 20, 5:40 PM
Unknown Object (File)
Wed, Nov 20, 5:40 PM
Unknown Object (File)
Wed, Nov 20, 5:40 PM
Unknown Object (File)
Wed, Nov 20, 5:40 PM
Unknown Object (File)
Wed, Nov 20, 5:35 PM
Unknown Object (File)
Oct 22 2024, 1:00 PM
View All 96 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
kamil
ginsu
Commits
rCOMMfeb5be94bf6f: [lib] Move conversion function out of validation utils
Summary

Changes required for fixing ENG-4670 introduce some cyclic dependencies so we need to move some things around.

Test Plan

yarn test-all, yarn eslint, yarn flow-all

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

michal created this revision.Aug 21 2023, 1:48 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 21 2023, 1:48 AM
michal added a child revision: D8880: [keyserver] Convert urlInfo in website responders.Aug 21 2023, 1:57 AM
Harbormaster completed remote builds in B21933: Diff 30125.Aug 21 2023, 2:05 AM
michal requested review of this revision.Aug 21 2023, 2:05 AM
michal planned changes to this revision.Aug 21 2023, 8:00 AM
michal updated this revision to Diff 30145.Aug 21 2023, 8:22 AM

Remove unrelated changes

michal updated this revision to Diff 30146.Aug 21 2023, 8:25 AM

Fix

Harbormaster completed remote builds in B21948: Diff 30145.Aug 21 2023, 8:40 AM
Harbormaster completed remote builds in B21949: Diff 30146.Aug 21 2023, 8:42 AM
kamil accepted this revision.Aug 22 2023, 12:55 AM
This revision is now accepted and ready to land.Aug 22 2023, 12:55 AM
Closed by commit rCOMMfeb5be94bf6f: [lib] Move conversion function out of validation utils (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyAug 22 2023, 3:13 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMfeb5be94bf6f: [lib] Move conversion function out of validation utils.

Revision Contents
Changeset List

PathSize
keyserver/
src/
utils/
8 lines
lib/
selectors/
7 lines
utils/
conversion-utils.js
validation-utils.js
129 lines
69 lines
119 lines
67 lines

Diff 30145

View Options

keyserver/src/utils/validation-utils.js

Loading...
View Options

lib/selectors/socket-selectors.js

Loading...
View Options

lib/utils/conversion-utils.js

Loading...
View Options

lib/utils/conversion-utils.test.js

Loading...
View Options

lib/utils/validation-utils.js

Loading...
View Options

lib/utils/validation-utils.test.js

Loading...