Page MenuHomePhabricator

[native] add BottomSheetModalProvider to the root component
ClosedPublic

Authored by ginsu on Aug 24 2023, 1:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 20, 9:30 AM
Unknown Object (File)
Sun, Oct 20, 9:30 AM
Unknown Object (File)
Sun, Oct 20, 9:30 AM
Unknown Object (File)
Sun, Oct 20, 9:29 AM
Unknown Object (File)
Sun, Oct 20, 9:24 AM
Unknown Object (File)
Oct 1 2024, 3:17 AM
Unknown Object (File)
Sep 15 2024, 8:56 AM
Unknown Object (File)
Sep 14 2024, 8:44 PM
Subscribers

Details

Summary

This diff adds the BottomSheetModalProvider to our tree of providers in the root component. We need to add this provider so we can open up and use the bottom sheet from anywhere in the app

Used the following docs to help me with this implementation:

Test Plan

Please see demo video below showing that I can present the bottom sheet

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu edited the summary of this revision. (Show Details)
ginsu added inline comments.
native/root.react.js
271 ↗(On Diff #30284)

Decided to stick this right under the ActionSheetProvider. Eventually once we fully move onto the bottomsheet we should be able to remove the ActionSheetProvider

ginsu requested review of this revision.Aug 24 2023, 1:22 PM

Haven't seen how BottomSheetModalProvider was implemented, but this seems like a reasonable place to place the provider in the hierarchy.

This revision is now accepted and ready to land.Aug 27 2023, 10:38 AM
ginsu edited the summary of this revision. (Show Details)

rebase before landing