Page MenuHomePhabricator

[native] move BottomSheetModalProvider to inside NavigationContainer
ClosedPublic

Authored by ginsu on Wed, Sep 6, 1:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 2, 6:45 AM
Unknown Object (File)
Mon, Sep 25, 10:45 PM
Unknown Object (File)
Sun, Sep 24, 12:53 PM
Unknown Object (File)
Sun, Sep 24, 11:04 AM
Unknown Object (File)
Sun, Sep 24, 9:12 AM
Unknown Object (File)
Fri, Sep 15, 7:36 AM
F746706: Screenshot 2023-09-06 at 3.48.35 PM.png
Thu, Sep 7, 11:12 AM
Subscribers

Details

Summary

In D8935 I add the BottomSheetModalProvider to the root component; however, I made a mistake where I added it in the wrong place. Since we are navigating to our bottomsheets we actually want this provider to be inside NavigationContainer

Depends on D9101

Test Plan

Was initially getting the following error; however, after I created this diff the error does not appear and I was able to navigate to the

Screenshot 2023-09-06 at 3.48.35 PM.png (1×1 px, 803 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Wed, Sep 6, 1:20 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.

Sequenced this diff after D9101 in the stack so that this diff felt less "random" and that there should be more context for this after reading D9101

This revision is now accepted and ready to land.Fri, Sep 8, 3:52 AM
This revision was landed with ongoing or failed builds.Tue, Sep 12, 2:31 PM
This revision was automatically updated to reflect the committed changes.