Page MenuHomePhabricator
Differential D9094

[native] move BottomSheetModalProvider to inside NavigationContainer
ClosedPublic
Actions

Authored by ginsu on Sep 6 2023, 1:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 3:55 AM
Unknown Object (File)
Sat, Nov 9, 3:12 AM
Unknown Object (File)
Sun, Nov 3, 4:56 PM
Unknown Object (File)
Sun, Nov 3, 1:47 PM
Unknown Object (File)
Sat, Nov 2, 12:26 PM
Unknown Object (File)
Fri, Nov 1, 12:47 PM
Unknown Object (File)
Wed, Oct 30, 5:17 AM
Unknown Object (File)
Oct 20 2024, 9:30 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM1a2f231b3f23: [native] move BottomSheetModalProvider to inside NavigationContainer
Summary

In D8935 I add the BottomSheetModalProvider to the root component; however, I made a mistake where I added it in the wrong place. Since we are navigating to our bottomsheets we actually want this provider to be inside NavigationContainer

Depends on D9101

Test Plan

Was initially getting the following error; however, after I created this diff the error does not appear and I was able to navigate to the

Screenshot 2023-09-06 at 3.48.35 PM.png (1×1 px, 803 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Sep 6 2023, 1:01 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 6 2023, 1:01 PM
Harbormaster completed remote builds in B22411: Diff 30805.Sep 6 2023, 1:20 PM
ginsu requested review of this revision.Sep 6 2023, 1:20 PM
ginsu edited the summary of this revision. (Show Details)Sep 7 2023, 11:12 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9101: [native] introduce user profile bottomsheet component.
ginsu attached a referenced file: F746706: Screenshot 2023-09-06 at 3.48.35 PM.png. (Show Details)
ginsu added a comment.Sep 7 2023, 11:14 AM

Sequenced this diff after D9101 in the stack so that this diff felt less "random" and that there should be more context for this after reading D9101

inka accepted this revision.Sep 8 2023, 3:52 AM
This revision is now accepted and ready to land.Sep 8 2023, 3:52 AM
ginsu added a child revision: D9119: [native] use stringForUserExplicit function to determine username text for profiles.Sep 10 2023, 11:00 PM
ginsu updated this revision to Diff 31003.Sep 12 2023, 2:21 PM

rebase before landing

This revision was landed with ongoing or failed builds.Sep 12 2023, 2:31 PM
Closed by commit rCOMM1a2f231b3f23: [native] move BottomSheetModalProvider to inside NavigationContainer (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM1a2f231b3f23: [native] move BottomSheetModalProvider to inside NavigationContainer.
Harbormaster completed remote builds in B22556: Diff 31003.Sep 12 2023, 2:40 PM

Revision Contents
Changeset List

PathSize
native/
76 lines

Diff 31003

View Options

native/root.react.js

Loading...