Page MenuHomePhabricator

[native] introduce onClosed callback prop to BottomSheet component
ClosedPublic

Authored by ginsu on Sep 7 2023, 9:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 7 2024, 4:20 AM
Unknown Object (File)
Sep 7 2024, 4:20 AM
Unknown Object (File)
Sep 7 2024, 4:19 AM
Unknown Object (File)
Sep 7 2024, 4:16 AM
Unknown Object (File)
Aug 10 2024, 10:54 PM
Unknown Object (File)
Aug 9 2024, 8:05 PM
Unknown Object (File)
Aug 9 2024, 9:52 AM
Unknown Object (File)
Aug 9 2024, 2:46 AM
Subscribers

Details

Summary

In subsequent diffs we will introduce some logic where we want to navigate back from the modal bottom sheet screen back to the screen we originally were before we opened/navigated to the modal bottom sheet screen when the bottomsheet closes. Unfortunately, the bottom sheet library does not have a callback prop for this. However, it does have a callback prop called onChange that gets triggered every time the sheet position changes. We can use this and set a condition where if the sheet position index is -1 (the sheet is closed) then we call the onClosed callback prop

https://gorhom.github.io/react-native-bottom-sheet/props/#onchange

Test Plan

Passed in a callback which logged a message to the console as the onClosed prop and confirmed that the message appeared when the bottomsheet closed

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable