[native] make bottomsheet snap point dynamic
ClosedPublic
Actions

Authored by ginsu on Sep 24 2023, 11:44 PM.

Details

Reviewers

atul
inka

Commits

rCOMM050b1af776c0: [native] make bottomsheet snap point dynamic

Summary

This diff replaces the hardcoded snap point I set earlier with a snap point that is based off the height of the bottomsheet container. With this new dynamic snap point, the bottom sheet will always update and change it's snap point whenever the height of the container changes (for example when we add or remove a button on the user profile component)

Depends on D9273

Test Plan

Please see the demo videos below

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Sep 24 2023, 11:44 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 24 2023, 11:44 PM

ginsu edited the summary of this revision. (Show Details)Sep 24 2023, 11:52 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D9273: [native] factor out UserProfileRelationshipButton condtionals.

ginsu attached a referenced file: F772686: Screen Recording 2023-09-25 at 2.50.56 AM.mov. (Show Details)

ginsu added inline comments.Sep 24 2023, 11:56 PM

native/user-profile/user-profile-relationship-button.react.js
55 ↗	(On Diff #31383)	Since we want to measure the height of the user profile bottom sheet before the elements/components get painted on the screen, we should use a `useLayoutEffect` here https://chat.openai.com/c/81792e1b-b517-47e3-9b0c-1eda21d8a8f9 https://react.dev/reference/react/useLayoutEffect#measuring-layout-before-the-browser-repaints-the-screen