Page MenuHomePhabricator
Differential D8935

[native] add BottomSheetModalProvider to the root component
ClosedPublic
Actions

Authored by ginsu on Aug 24 2023, 1:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 2:04 PM
Unknown Object (File)
Mon, Nov 25, 6:44 AM
Unknown Object (File)
Mon, Nov 25, 4:26 AM
Unknown Object (File)
Mon, Nov 4, 2:09 PM
Unknown Object (File)
Sun, Nov 3, 1:47 PM
Unknown Object (File)
Oct 20 2024, 9:30 AM
Unknown Object (File)
Oct 20 2024, 9:30 AM
Unknown Object (File)
Oct 20 2024, 9:30 AM
View All 79 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM5ec0ae679448: [native] add BottomSheetModalProvider to the root component
Summary

This diff adds the BottomSheetModalProvider to our tree of providers in the root component. We need to add this provider so we can open up and use the bottom sheet from anywhere in the app

Used the following docs to help me with this implementation:

Test Plan

Please see demo video below showing that I can present the bottom sheet

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Aug 24 2023, 1:01 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 24 2023, 1:01 PM
ginsu edited the summary of this revision. (Show Details)Aug 24 2023, 1:05 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu edited the summary of this revision. (Show Details)
ginsu attached a referenced file: F712091: Screen Recording 2023-08-24 at 4.04.41 PM.mov. (Show Details)
ginsu added inline comments.
native/root.react.js
271

Decided to stick this right under the ActionSheetProvider. Eventually once we fully move onto the bottomsheet we should be able to remove the ActionSheetProvider

Harbormaster completed remote builds in B22060: Diff 30284.Aug 24 2023, 1:22 PM
ginsu requested review of this revision.Aug 24 2023, 1:22 PM
ginsu added a child revision: D8955: [native] introduce barebones bottom sheet component.Aug 25 2023, 11:21 AM
atul accepted this revision.Aug 27 2023, 10:38 AM

Haven't seen how BottomSheetModalProvider was implemented, but this seems like a reasonable place to place the provider in the hierarchy.

This revision is now accepted and ready to land.Aug 27 2023, 10:38 AM
ginsu updated this revision to Diff 30448.Aug 28 2023, 8:31 AM
ginsu edited the summary of this revision. (Show Details)

rebase before landing

Harbormaster completed remote builds in B22177: Diff 30448.Aug 28 2023, 8:48 AM
Closed by commit rCOMM5ec0ae679448: [native] add BottomSheetModalProvider to the root component (authored by ginsu). · Explain WhyAug 28 2023, 9:05 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM5ec0ae679448: [native] add BottomSheetModalProvider to the root component.
ginsu mentioned this in D9094: [native] move BottomSheetModalProvider to inside NavigationContainer.Sep 6 2023, 1:01 PM
ginsu mentioned this in rCOMM1a2f231b3f23: [native] move BottomSheetModalProvider to inside NavigationContainer.Sep 12 2023, 2:31 PM

Revision Contents
Changeset List

PathSize
native/
67 lines

Diff 30284

View Options

native/root.react.js

Loading...