Paths

Table of Contentst

Differential D9022

[lib][native][web] Use connection from keyserverStore
ClosedPublic
Actions

Authored by inka on Aug 30 2023, 5:32 AM.

Tags

None

Referenced Files

	F3868415: D9022.diff
	Wed, Jan 22, 2:25 PM

	Unknown Object (File)
	Wed, Jan 15, 7:50 AM

	Unknown Object (File)
	Thu, Jan 9, 2:35 AM

	Unknown Object (File)
	Wed, Jan 8, 5:44 PM

	Unknown Object (File)
	Wed, Jan 8, 5:44 PM

	Unknown Object (File)
	Mon, Jan 6, 5:28 PM

	Unknown Object (File)
	Sun, Dec 29, 11:53 AM

	Unknown Object (File)
	Dec 16 2024, 9:47 PM

View All 76 Files

Subscribers

Details

Reviewers

michal
kamil

Commits

rCOMMa1d0af4669e0: [lib][native][web] Use connection from keyserverStore

Summary

issue: https://linear.app/comm/issue/ENG-4460/refactor-connection-field
This diff is the same as D8931 apart from the fact that we no longer need to introduce any changes in reduceConnectionInfo

Test Plan

ran yarn flow-all. Checked that the app works, and the "Disconnected" bar is not present when app is connected, and is present when keyserver is down.

Diff Detail

Repository

Branch

inka/connection

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Aug 30 2023, 5:32 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 30 2023, 5:32 AM

inka added a parent revision: D9021: [keyserver][lib][native] Add connection to keyserverStore.Aug 30 2023, 5:32 AM

inka added a child revision: D9023: [keyserver][lib][native][web] Remove connection field from redux.Aug 30 2023, 5:42 AM

Harbormaster completed remote builds in B22248: Diff 30545.Aug 30 2023, 5:49 AM

inka requested review of this revision.Aug 30 2023, 5:49 AM

michal accepted this revision.Aug 30 2023, 6:14 AM

This revision is now accepted and ready to land.Aug 30 2023, 6:14 AM

Closed by commit rCOMMa1d0af4669e0: [lib][native][web] Use connection from keyserverStore (authored by inka). · Explain WhyAug 31 2023, 5:19 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMa1d0af4669e0: [lib][native][web] Use connection from keyserverStore.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

disconnected-bar.js

25 lines

reducers/

master-reducer.js

3 lines

selectors/

keyserver-selectors.js

6 lines

server-calls.js

14 lines

socket/

activity-handler.react.js

5 lines

api-request-handler.react.js

6 lines

calendar-query-handler.react.js

5 lines

request-response-handler.react.js

5 lines

update-handler.react.js

6 lines

utils/

action-utils.js

8 lines

native/

calendar/

calendar.react.js

5 lines

7 lines

media/

encrypted-image.react.js

6 lines

remote-image.react.js

6 lines

push/

push-handler.react.js

9 lines

socket.react.js

4 lines

web/

calendar/

7 lines

socket.react.js

4 lines

Diff 30545

lib/hooks/disconnected-bar.js

Loading...

lib/reducers/master-reducer.js

Loading...

lib/selectors/keyserver-selectors.js

Loading...

lib/selectors/server-calls.js

Loading...

lib/socket/activity-handler.react.js

Loading...

lib/socket/api-request-handler.react.js

Loading...

lib/socket/calendar-query-handler.react.js

Loading...

lib/socket/request-response-handler.react.js

Loading...

lib/socket/update-handler.react.js

Loading...

lib/utils/action-utils.js

Loading...

native/calendar/calendar.react.js

Loading...

native/calendar/entry.react.js

Loading...

native/media/encrypted-image.react.js

Loading...

native/media/remote-image.react.js

Loading...

native/push/push-handler.react.js

Loading...

native/socket.react.js

Loading...

web/calendar/entry.react.js

Loading...

web/socket.react.js

Loading...