Paths

Table of Contentst

[lib] Move pendingThreadIDRegex to validation-utils.js
ClosedPublic
Actions

Authored by • patryk on Sep 1 2023, 8:50 AM.

Details

Reviewers

michal
inka
bartek
tomek

Commits

rCOMM043aed1fc0cf: [lib] Move pendingThreadIDRegex to validation-utils.js

Summary

Solution for ENG-4835

Test Plan

Check if all files import pendingThreadIDRegex from validation-utils.js and if error doesn't appear on web.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• patryk created this revision.Sep 1 2023, 8:50 AM

• patryk held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 1 2023, 8:50 AM

• patryk published this revision for review.Sep 1 2023, 8:53 AM

• patryk edited the summary of this revision. (Show Details)

• patryk edited the test plan for this revision. (Show Details)

• patryk added reviewers: michal, inka, bartek.

• patryk added a reviewer: tomek.Sep 1 2023, 9:03 AM

Harbormaster completed remote builds in B22351: Diff 30705.Sep 1 2023, 9:08 AM

• patryk edited the test plan for this revision. (Show Details)Sep 3 2023, 10:38 PM

bartek accepted this revision.Sep 4 2023, 12:25 AM

This revision is now accepted and ready to land.Sep 4 2023, 12:25 AM

Closed by commit rCOMM043aed1fc0cf: [lib] Move pendingThreadIDRegex to validation-utils.js (authored by • patryk). · Explain WhySep 4 2023, 1:14 AM

This revision was automatically updated to reflect the committed changes.

• patryk added a commit: rCOMM043aed1fc0cf: [lib] Move pendingThreadIDRegex to validation-utils.js.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

5 lines

utils/

url-utils.js

8 lines

validation-utils.js

3 lines

Diff 30728

View Options

lib/shared/thread-utils.js

View Options

lib/utils/url-utils.js

View Options

lib/utils/validation-utils.js

[lib] Move pendingThreadIDRegex to validation-utils.jsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30728

lib/shared/thread-utils.js

lib/utils/url-utils.js

lib/utils/validation-utils.js

[lib] Move pendingThreadIDRegex to validation-utils.js
ClosedPublic
Actions

Revision Contents
Changeset List