[keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux top level
ClosedPublic
Actions

Authored by inka on Sep 5 2023, 3:02 AM.

Details

Reviewers

michal
kamil

Commits

rCOMMee0c28bf7e17: [keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux…

Summary

issue: https://linear.app/comm/issue/ENG-4462/refactor-lastcommunicatedplatformdetails-field
The last step is to remove lastCommunicatedPlatformDetails from top level of redux store

Test Plan

ran yarn flow-all. Checked that both migrations work.

Diff Detail

Repository

rCOMM Comm

Branch

inka/redux4

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Sep 5 2023, 3:02 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 5 2023, 3:02 AM

inka edited the summary of this revision. (Show Details)Sep 5 2023, 3:05 AM

inka edited the test plan for this revision. (Show Details)

inka added a parent revision: D9079: [lib][web][native] Start using lastCommunicatedPlatformDetailsSelector from keyserverStore.Sep 5 2023, 3:13 AM

Harbormaster completed remote builds in B22379: Diff 30746.Sep 5 2023, 3:19 AM

inka requested review of this revision.Sep 5 2023, 3:19 AM

Need to add migrations

Add migrations

inka edited the test plan for this revision. (Show Details)Sep 5 2023, 3:49 AM

Harbormaster completed remote builds in B22381: Diff 30748.Sep 5 2023, 4:06 AM

LGTM, could you check that it still works with something like this:

Disable the websocket
Bump the webAndKeyserverCodeVersion version
Send a message or do something else that will call an endpoint
Check that redux has updated

This revision is now accepted and ready to land.Sep 5 2023, 5:56 AM

In D9078#267511, @michal wrote:

LGTM, could you check that it still works with something like this:

Disable the websocket

Bump the webAndKeyserverCodeVersion version

Send a message or do something else that will call an endpoint

Check that redux has updated