Page MenuHomePhabricator
Differential D9129

[lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object
ClosedPublic
Actions

Authored by varun on Sep 11 2023, 10:37 AM.
Tags
None
Referenced Files
F3570137: D9129.diff
Sat, Dec 28, 3:54 AM
Unknown Object (File)
Tue, Dec 17, 8:01 AM
Unknown Object (File)
Sun, Dec 15, 3:59 AM
Unknown Object (File)
Sun, Dec 15, 3:59 AM
Unknown Object (File)
Sun, Dec 15, 3:59 AM
Unknown Object (File)
Sun, Dec 15, 3:59 AM
Unknown Object (File)
Sun, Dec 15, 3:58 AM
Unknown Object (File)
Sun, Dec 15, 3:46 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
marcin
ashoat
Commits
rCOMM5e71db19bf33: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object
Summary

we need to do this in web/native(/keyserver?) so created a small utility function

Depends on D9127

Test Plan

called the function and got back an array of keys

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Sep 11 2023, 10:37 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 11 2023, 10:37 AM
Harbormaster completed remote builds in B22501: Diff 30934.Sep 11 2023, 10:56 AM
varun requested review of this revision.Sep 11 2023, 10:56 AM
marcin accepted this revision.Sep 12 2023, 2:17 AM
This revision is now accepted and ready to land.Sep 12 2023, 2:17 AM
ashoat requested changes to this revision.Sep 12 2023, 11:28 AM

Can we dedup this with the existing getOneTimeKeyValues? Looks like D8751 moves it around.

It looks like that one does JSON.parse and this one doesn't... if necessary we can keep two of them around, but:

  1. They should be in the same place
  2. One should call the other
  3. They should have different names
This revision now requires changes to proceed.Sep 12 2023, 11:28 AM
ashoat added a comment.Sep 13 2023, 7:04 AM

D8751 has been landed now, so it should be easier to dedup :)

varun updated this revision to Diff 31091.Sep 13 2023, 11:41 AM

address feedback

varun added a comment.Sep 13 2023, 11:42 AM

I found it confusing that we were using oneTimeKey instead of oneTimeKeys for arrays of keys so I changed that as well here

Harbormaster failed remote builds in B22612: Diff 31091!Sep 13 2023, 11:53 AM
varun updated this revision to Diff 31093.Sep 13 2023, 12:00 PM

resolve ESLint/Flow/Jest issues

Harbormaster completed remote builds in B22614: Diff 31093.Sep 13 2023, 12:18 PM
ashoat accepted this revision.Sep 13 2023, 12:24 PM

Thanks!!

This revision is now accepted and ready to land.Sep 13 2023, 12:24 PM
Closed by commit rCOMM5e71db19bf33: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object (authored by varun). · Explain WhySep 14 2023, 9:26 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM5e71db19bf33: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object.

Revision Contents
Changeset List

PathSize
keyserver/
src/
user/
33 lines
utils/
18 lines
lib/
shared/
17 lines

Diff 31144

View Options

keyserver/src/user/login.js

Loading...
View Options

keyserver/src/utils/olm-utils.js

Loading...
View Options

lib/shared/crypto-utils.js

Loading...