Page MenuHomePhabricator
Differential D9085

[native] getNotificationsOneTimeKeys
ClosedPublic
Actions

Authored by varun on Sep 5 2023, 7:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 12, 4:20 PM
Unknown Object (File)
Mar 16 2025, 11:15 PM
Unknown Object (File)
Mar 16 2025, 11:15 PM
Unknown Object (File)
Mar 16 2025, 11:14 PM
Unknown Object (File)
Mar 12 2025, 10:21 PM
Unknown Object (File)
Mar 7 2025, 10:15 PM
Unknown Object (File)
Mar 4 2025, 7:34 AM
Unknown Object (File)
Mar 4 2025, 7:27 AM
View All Files
Subscribers
ashoat
bartek
tomek

Details

Reviewers
marcin
atul
Commits
rCOMM0fbe980d5a9e: [native] getNotificationsOneTimeKeys
Summary

we need to send the identity service notif one-time keys

Depends on D9084

Test Plan

console logged the one-time keys in account-selectors.js
tested more in subsequent diff when register_user is called

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Sep 5 2023, 7:32 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 5 2023, 7:32 AM
Harbormaster completed remote builds in B22389: Diff 30775.Sep 5 2023, 7:50 AM
varun requested review of this revision.Sep 5 2023, 7:50 AM
marcin accepted this revision.Sep 6 2023, 1:47 AM
atul resigned from this revision.Sep 6 2023, 2:07 PM
atul added a subscriber: bartek.
atul added inline comments.
native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp
209–213 ↗(On Diff #30775)

Don't understand what's going on here, would want @marcin or @bartek to take a closer look

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.h
36 ↗(On Diff #30775)

I'd prefer something like numberOfKeys but feel free to go with whatever

This revision is now accepted and ready to land.Sep 6 2023, 2:07 PM
varun added a child revision: D9113: [native] get notifications one time keys.Sep 8 2023, 9:33 AM
Closed by commit rCOMM0fbe980d5a9e: [native] getNotificationsOneTimeKeys (authored by varun). · Explain WhySep 12 2023, 12:54 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM0fbe980d5a9e: [native] getNotificationsOneTimeKeys.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
Notifications/
BackgroundDataStorage/
3 lines
12 lines

Diff 30982

View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.h

Show All 23 Linesimport {
useDispatchActionPromise, useDispatchActionPromise,
} from '../utils/action-utils.js'; } from '../utils/action-utils.js';
const notFriendNotice = 'not friend'; const notFriendNotice = 'not friend';
function getPotentialMemberItems( function getPotentialMemberItems(
text: string, text: string,
userInfos: { +[id: string]: AccountUserInfo }, userInfos: { +[id: string]: AccountUserInfo },
searchIndex: SearchIndex, inputSearchIndex: SearchIndex | $ReadOnlyArray<SearchIndex>,
excludeUserIDs: $ReadOnlyArray<string>, excludeUserIDs: $ReadOnlyArray<string>,
inputParentThreadInfo: ?ThreadInfo, inputParentThreadInfo: ?ThreadInfo,
inputCommunityThreadInfo: ?ThreadInfo, inputCommunityThreadInfo: ?ThreadInfo,
threadType: ?ThreadType, threadType: ?ThreadType,
): UserListItem[] { ): UserListItem[] {
const searchIndexes = Array.isArray(inputSearchIndex)
? inputSearchIndex
: [inputSearchIndex];
const communityThreadInfo = const communityThreadInfo =
inputCommunityThreadInfo && inputCommunityThreadInfo.id !== genesis.id inputCommunityThreadInfo && inputCommunityThreadInfo.id !== genesis.id
? inputCommunityThreadInfo ? inputCommunityThreadInfo
: null; : null;
const parentThreadInfo = const parentThreadInfo =
inputParentThreadInfo && inputParentThreadInfo.id !== genesis.id inputParentThreadInfo && inputParentThreadInfo.id !== genesis.id
? inputParentThreadInfo ? inputParentThreadInfo
: null; : null;
Show All 10 Lines): UserListItem[] {
} }
let results = []; let results = [];
const appendUserInfo = (userInfo: AccountUserInfo) => { const appendUserInfo = (userInfo: AccountUserInfo) => {
const { id } = userInfo; const { id } = userInfo;
if (excludeUserIDs.includes(id)) { if (excludeUserIDs.includes(id)) {
return; return;
} }
if (results.some(item => item.id === id)) {
return;
}
if ( if (
communityThreadInfo && communityThreadInfo &&
!threadMemberHasPermission( !threadMemberHasPermission(
communityThreadInfo, communityThreadInfo,
id, id,
threadPermissions.KNOW_OF, threadPermissions.KNOW_OF,
) )
) { ) {
return; return;
} }
results.push({ results.push({
...userInfo, ...userInfo,
isMemberOfParentThread: userIsMember(parentThreadInfo, id), isMemberOfParentThread: userIsMember(parentThreadInfo, id),
isMemberOfContainingThread: userIsMember(containingThreadInfo, id), isMemberOfContainingThread: userIsMember(containingThreadInfo, id),
}); });
}; };
if (text === '') { if (text === '') {
for (const id in userInfos) { for (const id in userInfos) {
appendUserInfo(userInfos[id]); appendUserInfo(userInfos[id]);
} }
} else { } else {
for (const searchIndex of searchIndexes) {
const ids = searchIndex.getSearchResults(text); const ids = searchIndex.getSearchResults(text);
for (const id of ids) { for (const id of ids) {
appendUserInfo(userInfos[id]); appendUserInfo(userInfos[id]);
} }
} }
}
const blockedRelationshipsStatuses = new Set([ const blockedRelationshipsStatuses = new Set([
userRelationshipStatus.BLOCKED_BY_VIEWER, userRelationshipStatus.BLOCKED_BY_VIEWER,
userRelationshipStatus.BLOCKED_VIEWER, userRelationshipStatus.BLOCKED_VIEWER,
userRelationshipStatus.BOTH_BLOCKED, userRelationshipStatus.BOTH_BLOCKED,
]); ]);
if (text === '') { if (text === '') {
▲ Show 20 Lines • Show All 119 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp

Show All 23 Linesimport {
useDispatchActionPromise, useDispatchActionPromise,
} from '../utils/action-utils.js'; } from '../utils/action-utils.js';
const notFriendNotice = 'not friend'; const notFriendNotice = 'not friend';
function getPotentialMemberItems( function getPotentialMemberItems(
text: string, text: string,
userInfos: { +[id: string]: AccountUserInfo }, userInfos: { +[id: string]: AccountUserInfo },
searchIndex: SearchIndex, inputSearchIndex: SearchIndex | $ReadOnlyArray<SearchIndex>,
excludeUserIDs: $ReadOnlyArray<string>, excludeUserIDs: $ReadOnlyArray<string>,
inputParentThreadInfo: ?ThreadInfo, inputParentThreadInfo: ?ThreadInfo,
inputCommunityThreadInfo: ?ThreadInfo, inputCommunityThreadInfo: ?ThreadInfo,
threadType: ?ThreadType, threadType: ?ThreadType,
): UserListItem[] { ): UserListItem[] {
const searchIndexes = Array.isArray(inputSearchIndex)
? inputSearchIndex
: [inputSearchIndex];
const communityThreadInfo = const communityThreadInfo =
inputCommunityThreadInfo && inputCommunityThreadInfo.id !== genesis.id inputCommunityThreadInfo && inputCommunityThreadInfo.id !== genesis.id
? inputCommunityThreadInfo ? inputCommunityThreadInfo
: null; : null;
const parentThreadInfo = const parentThreadInfo =
inputParentThreadInfo && inputParentThreadInfo.id !== genesis.id inputParentThreadInfo && inputParentThreadInfo.id !== genesis.id
? inputParentThreadInfo ? inputParentThreadInfo
: null; : null;
Show All 10 Lines): UserListItem[] {
} }
let results = []; let results = [];
const appendUserInfo = (userInfo: AccountUserInfo) => { const appendUserInfo = (userInfo: AccountUserInfo) => {
const { id } = userInfo; const { id } = userInfo;
if (excludeUserIDs.includes(id)) { if (excludeUserIDs.includes(id)) {
return; return;
} }
if (results.some(item => item.id === id)) {
return;
}
if ( if (
communityThreadInfo && communityThreadInfo &&
!threadMemberHasPermission( !threadMemberHasPermission(
communityThreadInfo, communityThreadInfo,
id, id,
threadPermissions.KNOW_OF, threadPermissions.KNOW_OF,
) )
) { ) {
return; return;
} }
results.push({ results.push({
...userInfo, ...userInfo,
isMemberOfParentThread: userIsMember(parentThreadInfo, id), isMemberOfParentThread: userIsMember(parentThreadInfo, id),
isMemberOfContainingThread: userIsMember(containingThreadInfo, id), isMemberOfContainingThread: userIsMember(containingThreadInfo, id),
}); });
}; };
if (text === '') { if (text === '') {
for (const id in userInfos) { for (const id in userInfos) {
appendUserInfo(userInfos[id]); appendUserInfo(userInfos[id]);
} }
} else { } else {
for (const searchIndex of searchIndexes) {
const ids = searchIndex.getSearchResults(text); const ids = searchIndex.getSearchResults(text);
for (const id of ids) { for (const id of ids) {
appendUserInfo(userInfos[id]); appendUserInfo(userInfos[id]);
} }
} }
}
const blockedRelationshipsStatuses = new Set([ const blockedRelationshipsStatuses = new Set([
userRelationshipStatus.BLOCKED_BY_VIEWER, userRelationshipStatus.BLOCKED_BY_VIEWER,
userRelationshipStatus.BLOCKED_VIEWER, userRelationshipStatus.BLOCKED_VIEWER,
userRelationshipStatus.BOTH_BLOCKED, userRelationshipStatus.BOTH_BLOCKED,
]); ]);
if (text === '') { if (text === '') {
▲ Show 20 Lines • Show All 119 Lines • Show Last 20 Lines