Paths

Table of Contentst

-
native/cpp/CommonCpp/Notifications/BackgroundDataStorage/
-
cpp/
-
CommonCpp/
-
Notifications/
-
BackgroundDataStorage/
-
NotificationsCryptoModule.h
-
NotificationsCryptoModule.cpp

[native] getNotificationsOneTimeKeys
ClosedPublic
Actions

Authored by varun on Sep 5 2023, 7:32 AM.

Details

Reviewers

marcin
atul

Commits

rCOMM0fbe980d5a9e: [native] getNotificationsOneTimeKeys

Summary

we need to send the identity service notif one-time keys

Depends on D9084

Test Plan

console logged the one-time keys in account-selectors.js
tested more in subsequent diff when register_user is called

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Sep 5 2023, 7:32 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 5 2023, 7:32 AM

Harbormaster completed remote builds in B22389: Diff 30775.Sep 5 2023, 7:50 AM

varun requested review of this revision.Sep 5 2023, 7:50 AM

marcin accepted this revision.Sep 6 2023, 1:47 AM

atul resigned from this revision.Sep 6 2023, 2:07 PM

atul added a subscriber: bartek.

atul added inline comments.

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp
209–213 ↗	(On Diff #30775)	Don't understand what's going on here, would want @marcin or @bartek to take a closer look
native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.h
36 ↗	(On Diff #30775)	I'd prefer something like `numberOfKeys` but feel free to go with whatever

This revision is now accepted and ready to land.Sep 6 2023, 2:07 PM

varun added a child revision: D9113: [native] get notifications one time keys.Sep 8 2023, 9:33 AM

Closed by commit rCOMM0fbe980d5a9e: [native] getNotificationsOneTimeKeys (authored by varun). · Explain WhySep 12 2023, 12:54 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM0fbe980d5a9e: [native] getNotificationsOneTimeKeys.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

Notifications/

BackgroundDataStorage/

NotificationsCryptoModule.h

3 lines

NotificationsCryptoModule.cpp

12 lines

Diff 30982

View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.h

	Show All 35 Lines
	import type { CommunityCreationMembersScreenParams } from '../community-creation/community-creation-members.react.js';			import type { CommunityCreationMembersScreenParams } from '../community-creation/community-creation-members.react.js';
	import type { ManagePublicLinkScreenParams } from '../invite-links/manage-public-link-screen.react.js';			import type { ManagePublicLinkScreenParams } from '../invite-links/manage-public-link-screen.react.js';
	import type { ViewInviteLinksScreenParams } from '../invite-links/view-invite-links-screen.react.js';			import type { ViewInviteLinksScreenParams } from '../invite-links/view-invite-links-screen.react.js';
	import type { ChatCameraModalParams } from '../media/chat-camera-modal.react.js';			import type { ChatCameraModalParams } from '../media/chat-camera-modal.react.js';
	import type { ImageModalParams } from '../media/image-modal.react.js';			import type { ImageModalParams } from '../media/image-modal.react.js';
	import type { ThreadAvatarCameraModalParams } from '../media/thread-avatar-camera-modal.react.js';			import type { ThreadAvatarCameraModalParams } from '../media/thread-avatar-camera-modal.react.js';
	import type { VideoPlaybackModalParams } from '../media/video-playback-modal.react.js';			import type { VideoPlaybackModalParams } from '../media/video-playback-modal.react.js';
	import type { CustomServerModalParams } from '../profile/custom-server-modal.react.js';			import type { CustomServerModalParams } from '../profile/custom-server-modal.react.js';
				import type { KeyserverSelectionBottomSheetParams } from '../profile/keyserver-selection-bottom-sheet.react.js';
	import type { UserRelationshipTooltipModalParams } from '../profile/user-relationship-tooltip-modal.react.js';			import type { UserRelationshipTooltipModalParams } from '../profile/user-relationship-tooltip-modal.react.js';
	import type { ChangeRolesScreenParams } from '../roles/change-roles-screen.react.js';			import type { ChangeRolesScreenParams } from '../roles/change-roles-screen.react.js';
	import type { CommunityRolesScreenParams } from '../roles/community-roles-screen.react.js';			import type { CommunityRolesScreenParams } from '../roles/community-roles-screen.react.js';
	import type { CreateRolesScreenParams } from '../roles/create-roles-screen.react.js';			import type { CreateRolesScreenParams } from '../roles/create-roles-screen.react.js';
	import type { MessageSearchParams } from '../search/message-search.react.js';			import type { MessageSearchParams } from '../search/message-search.react.js';
	import type { UserProfileAvatarModalParams } from '../user-profile/user-profile-avatar-modal.react.js';			import type { UserProfileAvatarModalParams } from '../user-profile/user-profile-avatar-modal.react.js';
	import type { UserProfileBottomSheetParams } from '../user-profile/user-profile-bottom-sheet.react.js';			import type { UserProfileBottomSheetParams } from '../user-profile/user-profile-bottom-sheet.react.js';

	▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines
	export const QRCodeSignInNavigatorRouteName = 'QRCodeSignInNavigator';			export const QRCodeSignInNavigatorRouteName = 'QRCodeSignInNavigator';
	export const QRCodeScreenRouteName = 'QRCodeScreen';			export const QRCodeScreenRouteName = 'QRCodeScreen';
	export const UserProfileBottomSheetNavigatorRouteName =			export const UserProfileBottomSheetNavigatorRouteName =
	'UserProfileBottomSheetNavigator';			'UserProfileBottomSheetNavigator';
	export const UserProfileBottomSheetRouteName = 'UserProfileBottomSheet';			export const UserProfileBottomSheetRouteName = 'UserProfileBottomSheet';
	export const UserProfileAvatarModalRouteName = 'UserProfileAvatarModal';			export const UserProfileAvatarModalRouteName = 'UserProfileAvatarModal';
	export const KeyserverSelectionListRouteName = 'KeyserverSelectionList';			export const KeyserverSelectionListRouteName = 'KeyserverSelectionList';
	export const AddKeyserverRouteName = 'AddKeyserver';			export const AddKeyserverRouteName = 'AddKeyserver';
				export const KeyserverSelectionBottomSheetRouteName =
				'KeyserverSelectionBottomSheet';

	export type RootParamList = {			export type RootParamList = {
	+LoggedOutModal: void,			+LoggedOutModal: void,
	+App: void,			+App: void,
	+ThreadPickerModal: ThreadPickerModalParams,			+ThreadPickerModal: ThreadPickerModalParams,
	+AddUsersModal: AddUsersModalParams,			+AddUsersModal: AddUsersModalParams,
	+CustomServerModal: CustomServerModalParams,			+CustomServerModal: CustomServerModalParams,
	+ColorSelectorModal: ColorSelectorModalParams,			+ColorSelectorModal: ColorSelectorModalParams,
	+ComposeSubchannelModal: ComposeSubchannelModalParams,			+ComposeSubchannelModal: ComposeSubchannelModalParams,
	+SidebarListModal: SidebarListModalParams,			+SidebarListModal: SidebarListModalParams,
	+ImagePasteModal: ImagePasteModalParams,			+ImagePasteModal: ImagePasteModalParams,
	+TermsAndPrivacyModal: TermsAndPrivacyModalParams,			+TermsAndPrivacyModal: TermsAndPrivacyModalParams,
	+SubchannelsListModal: SubchannelListModalParams,			+SubchannelsListModal: SubchannelListModalParams,
	+MessageReactionsModal: MessageReactionsModalParams,			+MessageReactionsModal: MessageReactionsModalParams,
	+Registration: void,			+Registration: void,
	+CommunityCreation: void,			+CommunityCreation: void,
	+InviteLinkModal: InviteLinkModalParams,			+InviteLinkModal: InviteLinkModalParams,
	+InviteLinkNavigator: void,			+InviteLinkNavigator: void,
	+RolesNavigator: void,			+RolesNavigator: void,
	+QRCodeSignInNavigator: void,			+QRCodeSignInNavigator: void,
	+UserProfileBottomSheetNavigator: void,			+UserProfileBottomSheetNavigator: void,
	+TunnelbrokerMenu: void,			+TunnelbrokerMenu: void,
				+KeyserverSelectionBottomSheet: KeyserverSelectionBottomSheetParams,
	};			};

	export type MessageTooltipRouteNames =			export type MessageTooltipRouteNames =
	\| typeof RobotextMessageTooltipModalRouteName			\| typeof RobotextMessageTooltipModalRouteName
	\| typeof MultimediaMessageTooltipModalRouteName			\| typeof MultimediaMessageTooltipModalRouteName
	\| typeof TextMessageTooltipModalRouteName;			\| typeof TextMessageTooltipModalRouteName;

	export const PinnableMessageTooltipRouteNames = [			export const PinnableMessageTooltipRouteNames = [
	▲ Show 20 Lines • Show All 161 Lines • Show Last 20 Lines