Page MenuHomePhabricator
Differential D9085

[native] getNotificationsOneTimeKeys
ClosedPublic
Actions

Authored by varun on Sep 5 2023, 7:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 17, 7:40 PM
Unknown Object (File)
Wed, May 1, 3:45 PM
Unknown Object (File)
Apr 15 2024, 8:48 PM
Unknown Object (File)
Apr 13 2024, 8:31 AM
Unknown Object (File)
Apr 12 2024, 6:20 PM
Unknown Object (File)
Apr 12 2024, 4:10 PM
Unknown Object (File)
Apr 12 2024, 12:23 AM
Unknown Object (File)
Apr 11 2024, 4:26 AM
View All 42 Files
Subscribers
ashoat
bartek
tomek

Details

Reviewers
marcin
atul
Commits
rCOMM0fbe980d5a9e: [native] getNotificationsOneTimeKeys
Summary

we need to send the identity service notif one-time keys

Depends on D9084

Test Plan

console logged the one-time keys in account-selectors.js
tested more in subsequent diff when register_user is called

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Sep 5 2023, 7:32 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 5 2023, 7:32 AM
Harbormaster completed remote builds in B22389: Diff 30775.Sep 5 2023, 7:50 AM
varun requested review of this revision.Sep 5 2023, 7:50 AM
marcin accepted this revision.Sep 6 2023, 1:47 AM
atul resigned from this revision.Sep 6 2023, 2:07 PM
atul added a subscriber: bartek.
atul added inline comments.
native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp
209–213 ↗(On Diff #30775)

Don't understand what's going on here, would want @marcin or @bartek to take a closer look

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.h
36 ↗(On Diff #30775)

I'd prefer something like numberOfKeys but feel free to go with whatever

This revision is now accepted and ready to land.Sep 6 2023, 2:07 PM
varun added a child revision: D9113: [native] get notifications one time keys.Sep 8 2023, 9:33 AM
Closed by commit rCOMM0fbe980d5a9e: [native] getNotificationsOneTimeKeys (authored by varun). · Explain WhySep 12 2023, 12:54 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM0fbe980d5a9e: [native] getNotificationsOneTimeKeys.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
Notifications/
BackgroundDataStorage/
3 lines
12 lines

Diff 30982

View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.h

Loading...
View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp

Loading...