Added a new action type and updated the reducer so we can set the token string in redux state
Depends on D9113
Details
Details
how i tested the SET_ACCESS_TOKEN action: https://gist.github.com/vdhanan/c1a70adc6125268a8f9a085f0b1fcea2
tested the other cases in reduceServicesAccessToken by logging out and deleting account on iOS simulator and dispatching a SET_NEW_SESSION action manually from the redux devtools (confirmed that the token was set to null in redux state in all these cases)
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/redux/action-types.js | ||
|---|---|---|
| 26 ↗ | (On Diff #30877) | Nit: Each type in this file ends with ActionType suffix so we should follow the convention here as well and rename this to setAccessTokenActionType. |
Comment Actions
- I think we should implement a separate reducer for this. We should expect that the access token will need to be cleared for a log out, account deletion, and session invalidation. For an example, see here
- I think the reducer should be in lib, since this action will be shared with web. I think it should be possible to submit this diff purely on lib, without touching native or web
- Please keep in mind that we will also need this info to be in CommSecureStore for @marcin's purposes, since he needs to be able to access it from native code (and NSE in particular)
| native/redux/action-types.js | ||
|---|---|---|
| 26 ↗ | (On Diff #30877) | Agree with this. Try to make sure you maintain consistency with the existing codebase... we can't rely on reviewers to always spot things like this |
Comment Actions
address feedback (CommSecureStore changes will come later, but wanted to acknowledge the comment)