This type is needed on native/web too so I'm moving it.
Depends on D9114
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/types/identity-service-types.js | ||
|---|---|---|
| 1 ↗ | (On Diff #30878) | Each time I am about to introduce new file I tend to ask myself whether it is possible to reuse already existing location and if it is would it be better to reuse or to introduce new file. How about putting this type into account-types? od merging it with LogInResponse? |
| lib/types/identity-service-types.js | ||
|---|---|---|
| 1 ↗ | (On Diff #30878) | I don't think it's bad for it to be in a separate file. That said, the annotation at the top of the file needs a space (see suggested edit) As mentioned here, @varun please try to maintain consistency on small things like this in the future. As evidenced by @marcin missing this, we simply can't rely on diff reviewers to catch small nits like this – it's on the diff author to do their best to match existing conventions |
| lib/types/identity-service-types.js | ||
|---|---|---|
| 1 ↗ | (On Diff #30878) | Most of the IDEs allow creating templates for files. In my case, I've configured that each new js file has // @flow at the start. You can consider doing something similar. |
| lib/types/identity-service-types.js | ||
|---|---|---|
| 1 ↗ | (On Diff #30878) | good tip! |